public inbox for debugedit@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: "Dmitry V. Levin" <ldv@altlinux.org>, debugedit@sourceware.org
Subject: Re: [PATCH 1/3] debugedit: skip .debug_types tests if compiler doesn't generate section
Date: Tue, 28 Mar 2023 13:24:58 +0200	[thread overview]
Message-ID: <d0c52b176d5f62fd2a2bf23b50580273f9a3635f.camel@klomp.org> (raw)
In-Reply-To: <20230325113043.GA19701@altlinux.org>

Hi Dmitry,

On Sat, 2023-03-25 at 14:30 +0300, Dmitry V. Levin wrote:
> On Sat, Mar 25, 2023 at 12:58:05AM +0100, Mark Wielaard wrote:
> > Some compilers don't generate a .debug_types section even when compiling
> > with -fdebug-types-section. Skip testing the .debug_types tests in that
> > case.
> > 
> >  DEBUGEDIT_SETUP([-fdebug-types-section -gdwarf-4])
> > +AT_SKIP_IF([! $READELF -S ./foo.o ./subdir_bar/bar.o ./baz.o | grep -q '.debug_types'])
> 
> Should it rather be grep -F -q?

Yes, that (--fixed-strings) would indeed be better.
Fixed in 3 places.

Thanks,

Mark

  reply	other threads:[~2023-03-28 11:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-24 23:58 Mark Wielaard
2023-03-24 23:58 ` [PATCH 2/3] debuginfo: check whether compiler needs -fdebug-macro Mark Wielaard
2023-03-24 23:58 ` [PATCH 3/3] debugedit: Simplify and extend .debug_line tests Mark Wielaard
2023-03-25 11:30 ` [PATCH 1/3] debugedit: skip .debug_types tests if compiler doesn't generate section Dmitry V. Levin
2023-03-28 11:24   ` Mark Wielaard [this message]
2023-04-21 12:46     ` Mark Wielaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d0c52b176d5f62fd2a2bf23b50580273f9a3635f.camel@klomp.org \
    --to=mark@klomp.org \
    --cc=debugedit@sourceware.org \
    --cc=ldv@altlinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).