public inbox for debugedit@sourceware.org
 help / color / mirror / Atom feed
From: Denys Vlasenko <dvlasenk@redhat.com>
To: Mark Wielaard <mark@klomp.org>
Cc: debugedit@sourceware.org, Prarit Bhargava <prarit@redhat.com>
Subject: Re: [PATCH] find-debuginfo: unless -q -q, print messages what big steps we are at
Date: Fri, 30 Jun 2023 20:51:35 +0200	[thread overview]
Message-ID: <2ebe27f4-2522-6257-7a38-f6b5adb00e68@redhat.com> (raw)
In-Reply-To: <025ec8a4f5e26a4f0f40b90776c9033b45299396.camel@klomp.org>

On 6/30/23 15:25, Mark Wielaard wrote:
> Hi Denys,
> 
> On Thu, 2023-06-29 at 16:13 +0200, Mark Wielaard wrote:
>>> We can give a few messages explaining what general steps we go through:
>>>
>>>      Extracting debug info from N files
>>>      DWARF-compressing N files
>>>      Creating .debug symlinks for symlinks to ELF files
>>>      Copying sources found by 'debugedit -l'
>>>
>>> This is also useful to get a feeling which steps are time consuming.
>>> Kernel builds often need to investigate this aspect. To help a bit more,
>>> add "find-debuginfo: starting" and "find-debuginfo: done" messages too.
>>>
>>> This patch adds these messages.
>>>
>>> Two -q -q options suppress these messages too.
>>
>> I like this idea, but I am wondering if instead of -q -q we should
>> have a -v,--verbose flag for the very verbose output. Then this
>> explanary output could be the default. And -q,--quiet would suppress
>> even those message.
> 
> So this is what I was thinking. What do you think?
> https://code.wildebeest.org/git/user/mjw/debugedit/commit/?h=verbose

Looks good. We will be able to revert

"Suppress 'extracting debug info' noise in build log"

+%if 0%{?fedora}
+%global _find_debuginfo_opts -r -q
+%else
  %global _find_debuginfo_opts -r
+%endif

change in our kernel specfile (always good to have fewer special cases)
and still have what that change intended: not-very-verbose find-debuginfo output.


  reply	other threads:[~2023-06-30 18:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-22 13:31 Denys Vlasenko
2023-06-29 14:13 ` Mark Wielaard
2023-06-30 13:25   ` Mark Wielaard
2023-06-30 18:51     ` Denys Vlasenko [this message]
2023-06-30 22:17       ` Mark Wielaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2ebe27f4-2522-6257-7a38-f6b5adb00e68@redhat.com \
    --to=dvlasenk@redhat.com \
    --cc=debugedit@sourceware.org \
    --cc=mark@klomp.org \
    --cc=prarit@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).