[Bug find-debuginfo.sh/27640] New: find-debuginfo.sh or find-debuginfo?

[Bug find-debuginfo.sh/27640] New: find-debuginfo.sh or find-debuginfo?

[doko at debian dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=27640

            Bug ID: 27640
           Summary: find-debuginfo.sh or find-debuginfo?
           Product: debugedit
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: find-debuginfo.sh
          Assignee: unassigned at sourceware dot org
          Reporter: doko at debian dot org
                CC: debugedit at sourceware dot org
  Target Milestone: ---

How should that be named, find-debuginfo.sh or find-debuginfo?

Usually the interpreter name is not included in the tool name.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug find-debuginfo.sh/27640] find-debuginfo.sh or find-debuginfo?

[mark at klomp dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=27640

Mark Wielaard <mark at klomp dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mark at klomp dot org,
                   |                            |pmatilai at redhat dot com

--- Comment #1 from Mark Wielaard <mark at klomp dot org> ---
It would be nice to rename it to simply find-debuginfo. But this might have
some backwards compatibility issues for rpm and old spec files which might rely
on the exact name. This might not be too strong an objection to renaming it
though. Up till now this was an internal detail of rpm.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug find-debuginfo.sh/27640] find-debuginfo.sh or find-debuginfo?

[pmatilai at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27640

--- Comment #2 from Panu Matilainen <pmatilai at redhat dot com> ---
Rpm will not mind renaming, but if you want to do it then please do it *now*
rather than some future point.

There are quite some packages directly referring
%{_rpmconfigdir}/find-debuginfo.sh or /usr/lib/rpm/find-debuginfo.sh, and as
the path will now change anyhow, I think rpm needs to setup a symlink pointing
to the real script at that location for backwards compat.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug find-debuginfo/27640] find-debuginfo.sh or find-debuginfo?

[mark at klomp dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=27640

Mark Wielaard <mark at klomp dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Mark Wielaard <mark at klomp dot org> ---
find-debuginfo (without .sh) it is (also changed the component name in
bugzilla)

commit 75e085aa341c247cdb47d9a40a6324f308ceccae
Author: Mark Wielaard <mark@klomp.org>
Date:   Tue May 18 19:03:31 2021 +0200

    Rename find-debuginfo.sh to find-debuginfo

    Even though it is currently a bash script we install it as a normal
    program. So simply install it without the .sh suffix. To get the VERSION
    right in the script make it an AC_CONFIG_FILE (from find-debuginfo.in).
    This also fixes the man page name and version.

            * .gitignore: Remove find-debuginfo.sh.1.
            Add scripts/find-debuginfo and find-debuginfo.1
            * configure.ac (AC_CONFIG_FILES): Add scripts/find-debuginfo.
            * Makefile.am (bin_SCRIPTS): Rename find-debuginfo.sh to
            find-debuginfo.
            (dist_man_MANS): Rename find-debuginfo.sh.1 to find-debuginfo.1.
            (find-debuginfo.sh.1): Rename to ...
            (find-debuginfo.1): ...this and update invocation.
            (EXTRA_DIST): Rename scripts/find-debuginfo.sh to
            scripts/find-debuginfo.
            * scripts/find-debuginfo.sh: Rename to ...
            * scripts/find-debuginfo.in: ...this.
            Change all find-debuginfo.sh to find-debuginfo.
            Use @VERSION@ for --version.

    Signed-off-by: Mark Wielaard <mark@klomp.org>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug find-debuginfo/27640] find-debuginfo.sh or find-debuginfo?

[pmatilai at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27640

--- Comment #4 from Panu Matilainen <pmatilai at redhat dot com> ---
Hey, could we have a new release with this change, even if only for that
particular purpose? I'd like to proceed from the rpm side, but I really don't
want to deal with multiple possible names when it's already decided that it'll
be one and not the other.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug find-debuginfo/27640] find-debuginfo.sh or find-debuginfo?

[ldv at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=27640

--- Comment #5 from Dmitry V. Levin <ldv at sourceware dot org> ---
(In reply to Panu Matilainen from comment #4)
> Hey, could we have a new release with this change, even if only for that
> particular purpose?

+1

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug find-debuginfo/27640] find-debuginfo.sh or find-debuginfo?

[mark at klomp dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=27640

--- Comment #6 from Mark Wielaard <mark at klomp dot org> ---
(In reply to Dmitry V. Levin from comment #5)
> (In reply to Panu Matilainen from comment #4)
> > Hey, could we have a new release with this change, even if only for that
> > particular purpose?
> 
> +1

debugedit 0.3 has been released!
https://sourceware.org/pub/debugedit/0.3/

For Fedora I did a build with a compatibility find-debuginfo.sh ->
find-debuginfo symlink for now to not accidentially break anything. But I'll
remove that for the next build.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug find-debuginfo/27640] find-debuginfo.sh or find-debuginfo?

[pmatilai at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27640

--- Comment #7 from Panu Matilainen <pmatilai at redhat dot com> ---
Perfect, thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.