public inbox for debugedit@sourceware.org
 help / color / mirror / Atom feed
From: "mark at klomp dot org" <sourceware-bugzilla@sourceware.org>
To: debugedit@sourceware.org
Subject: [Bug debugedit/31504] debugedit writes out ELF file even when nothing has been updated
Date: Wed, 15 May 2024 11:34:15 +0000	[thread overview]
Message-ID: <bug-31504-13298-QpjPQls8wE@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-31504-13298@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=31504

--- Comment #10 from Mark Wielaard <mark at klomp dot org> ---
(In reply to Jamin Collins from comment #9)
> why not simply have debugedit detect (or watch) whether it has accounted for
> the full file contents.  If it has, great, do its thing.  If it has not,
> leave the file untouched/altered.
> 
> If in the course of doing its work, debugedit does not account for the full
> file contents, then the file is (as has been indicated) not a proper spec
> conforming ELF file.  As such, debugedit (and other ELF tools) should
> probably leave the file as-is, unless explicitly told otherwise (perhaps an
> additional flag).

debugedit simply uses (elfutils) libelf. And libelf cannot really know whether
the "gaps" in the file are intentional or not. There are different structures
(section headers, program headers, section data) which can appear "randomly" in
the file, it isn't simply a stream. Only the start of the file (the ELF header)
is fixed, everything else can appear at some later point in the file in no
particular order and there can be gaps.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

      parent reply	other threads:[~2024-05-15 11:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-17 14:46 [Bug debugedit/31504] New: " mark at klomp dot org
2024-03-18  8:20 ` [Bug debugedit/31504] " sam at gentoo dot org
2024-03-18 22:40 ` mark at klomp dot org
2024-03-21  0:05 ` allan at archlinux dot org
2024-03-21 11:46 ` mark at klomp dot org
2024-03-21 12:07 ` mark at klomp dot org
2024-03-21 21:23 ` allan at archlinux dot org
2024-03-22 12:29 ` mark at klomp dot org
2024-03-22 22:13 ` allan at archlinux dot org
2024-03-22 23:47 ` mark at klomp dot org
2024-04-29 19:59 ` jamin.collins at gmail dot com
2024-05-15 11:34 ` mark at klomp dot org [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-31504-13298-QpjPQls8wE@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=debugedit@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).