From: Mark Wielaard <mark@klomp.org>
To: Jakub Jelinek <jakub@redhat.com>
Cc: dwz@sourceware.org
Subject: Re: [PATCH 2/4] Handle DWARF5 headers for compile and partial units.
Date: Tue, 15 Sep 2020 13:38:29 +0200 [thread overview]
Message-ID: <184ff133e361663c478ba33d7c2c6b3b84628fb7.camel@klomp.org> (raw)
In-Reply-To: <20200914103809.GY21814@tucnak>
Hi,
On Mon, 2020-09-14 at 12:38 +0200, Jakub Jelinek wrote:
> On Mon, Sep 14, 2020 at 12:23:53PM +0200, Mark Wielaard wrote:
> > + case DW_UT_compile: name = "DW_UT_compile"; break;
> > + case DW_UT_type: name = "DW_UT_type"; break;
> > + case DW_UT_partial: name = "DW_UT_partial"; break;
> > + case DW_UT_skeleton: name = "DW_UT_partial"; break;
>
> Pasto?
Yes, fixed.
> > + case DW_UT_split_compile: name = "DW_UT_split_compile"; break;
> > + case DW_UT_split_type: name = "DW_UT_split_type"; break;
> > + default: name = 0; break;
> > + }
> > @@ -5572,24 +5594,41 @@ try_debug_info (DSO *dso)
> > }
> >
> > cu_version = read_16 (ptr);
> > - if (cu_version < 2 || cu_version > 4)
> > + if (kind == DEBUG_TYPES &&
> > + (cu_version < 2 || cu_version > 4))
>
> I think dwz follows e.g. the GCC formatting and &&s etc. go
> to the start of line rather than end of it.
No idea why I did that. The line isn't too large, so I just kept it all
together (in both places).
> Ok with the nits fixed.
Thanks, pushed,
Mark
next prev parent reply other threads:[~2020-09-15 11:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 10:23 DWARF5 support for dwz Mark Wielaard
2020-09-14 10:23 ` [PATCH 1/4] Recognize some new DWARF5 .debug sections Mark Wielaard
2020-09-14 10:36 ` Jakub Jelinek
2020-09-14 10:23 ` [PATCH 2/4] Handle DWARF5 headers for compile and partial units Mark Wielaard
2020-09-14 10:38 ` Jakub Jelinek
2020-09-15 11:38 ` Mark Wielaard [this message]
2020-09-14 10:23 ` [PATCH 3/4] Handle new DWARF5 attributes Mark Wielaard
2020-09-14 10:38 ` Jakub Jelinek
2020-09-14 10:23 ` [PATCH 4/4] Handle new DWARF5 operations as their GNU extension variants Mark Wielaard
2020-09-14 10:39 ` Jakub Jelinek
2020-09-14 10:48 ` DWARF5 support for dwz Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=184ff133e361663c478ba33d7c2c6b3b84628fb7.camel@klomp.org \
--to=mark@klomp.org \
--cc=dwz@sourceware.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).