From: Jakub Jelinek <jakub@redhat.com>
To: Mark Wielaard <mark@klomp.org>
Cc: dwz@sourceware.org
Subject: Re: [PATCH 3/4] Handle new DWARF5 attributes.
Date: Mon, 14 Sep 2020 12:38:57 +0200 [thread overview]
Message-ID: <20200914103857.GZ21814@tucnak> (raw)
In-Reply-To: <20200914102355.8137-4-mark@klomp.org>
On Mon, Sep 14, 2020 at 12:23:54PM +0200, Mark Wielaard wrote:
> There are various new attributes that can hold exprlocs (DW_AT_rank,
> DW_AT_call_value, DW_AT_call_target, DW_AT_call_target_clobbered,
> DW_AT_call_data_location, DW_AT_call_data_value) or hold addresses
> (DW_AT_call_return_pc, DW_AT_call_pc).
>
> Note that DW_AT_call_origin is listed as also holding exprlocs,
> but that seems to be a bug in the spec:
> http://dwarfstd.org/ShowIssue.php?issue=171103.1
>
> There is a new DW_AT_macros that should work the same as DW_AT_GNU_macros.
>
> Currently unhandled are DW_AT_dwo_name, DW_AT_str_offsets_base,
> DW_AT_addr_base, DW_AT_rnglists_base and DW_AT_loclists_base which GCC
> only emits when generating split-dwarf.
>
> All other new attributes don't seem to need any special handling.
>
> * dwz.c (add_locexpr_dummy_dies): Handle DW_AT_rank,
> DW_AT_call_value, DW_AT_call_target, DW_AT_call_target_clobbered,
> DW_AT_call_data_location and DW_AT_call_data_value.
> (checksum_die): Handle DW_AT_call_return_pc, DW_AT_call_pc,
> DW_AT_macros, DW_AT_rank, DW_AT_call_value, DW_AT_call_target,
> DW_AT_call_target_clobbered, DW_AT_call_data_location,
> DW_AT_call_data_value, DW_AT_call_return_pc and DW_AT_call_pc.
> (die_eq_1): Handle DW_AT_call_return_pc and DW_AT_call_pc.
> (read_debug_info): Recognize all new DWARF5 attributes.
> (build_abbrevs_for_die): Deal with DW_AT_macros.
> (write_die): Likewise. And handle DW_AT_rank, DW_AT_call_value,
> DW_AT_call_target, DW_AT_call_target_clobbered,
> DW_AT_call_data_location and DW_AT_call_data_value.
LGTM.
Jakub
next prev parent reply other threads:[~2020-09-14 10:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 10:23 DWARF5 support for dwz Mark Wielaard
2020-09-14 10:23 ` [PATCH 1/4] Recognize some new DWARF5 .debug sections Mark Wielaard
2020-09-14 10:36 ` Jakub Jelinek
2020-09-14 10:23 ` [PATCH 2/4] Handle DWARF5 headers for compile and partial units Mark Wielaard
2020-09-14 10:38 ` Jakub Jelinek
2020-09-15 11:38 ` Mark Wielaard
2020-09-14 10:23 ` [PATCH 3/4] Handle new DWARF5 attributes Mark Wielaard
2020-09-14 10:38 ` Jakub Jelinek [this message]
2020-09-14 10:23 ` [PATCH 4/4] Handle new DWARF5 operations as their GNU extension variants Mark Wielaard
2020-09-14 10:39 ` Jakub Jelinek
2020-09-14 10:48 ` DWARF5 support for dwz Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200914103857.GZ21814@tucnak \
--to=jakub@redhat.com \
--cc=dwz@sourceware.org \
--cc=mark@klomp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).