Added a buildbot for dwz

Added a buildbot for dwz

[Mark Wielaard]

Hi,

To celebrate that dwz now has a testsuite I added a buildbot:
https://builder.wildebeest.org/buildbot/#/builders?tags=dwz

It monitors the dwz.git master branch and does a make && make check
on every new commit it sees for aarch64, armhf, ppc64, ppc64le, s390x,
x86_64 and i386.

The ppc64 and ppc64le builders currently fail because they
don't have dejagnu installed yet. As soon as that is installed
I expect those to also become green.

It should sent email to this list when a new failure is detected.

Cheers,

Mark

Re: Added a buildbot for dwz

[Tom de Vries]

> Hi,
> 
> To celebrate that dwz now has a testsuite I added a buildbot:
> https://builder.wildebeest.org/buildbot/#/builders?tags=dwz
> 
> It monitors the dwz.git master branch and does a make && make check
> on every new commit it sees for aarch64, armhf, ppc64, ppc64le, s390x,
> x86_64 and i386.
> 
> The ppc64 and ppc64le builders currently fail because they
> don't have dejagnu installed yet. As soon as that is installed
> I expect those to also become green.
> 
> It should sent email to this list when a new failure is detected.
> 

I've just pushed a fix for a dejagnu warning on my laptop, and there I
see no warnings anymore.

However, all builds on the build bot that I checked show:
...
WARNING: Couldn't find the global config file.
...

I'm not sure if this should be fixed on the buildbot, or in the sources.

Thanks,
- Tom

Re: Added a buildbot for dwz

[Mark Wielaard]

On Sat, Mar 16, 2019 at 04:23:25PM +0100, Tom de Vries wrote:
> > To celebrate that dwz now has a testsuite I added a buildbot:
> > https://builder.wildebeest.org/buildbot/#/builders?tags=dwz
> > 
> 
> I've just pushed a fix for a dejagnu warning on my laptop, and there I
> see no warnings anymore.
> 
> However, all builds on the build bot that I checked show:
> ...
> WARNING: Couldn't find the global config file.
> ...
> 
> I'm not sure if this should be fixed on the buildbot, or in the sources.

Apparently this comes from not setting the DEJAGNU variable:

	   There is an optional global site.exp, containing
	   configuration values that apply to DejaGnu
	   site-wide. runtest loads these values first. The global
	   site.exp contains the default values for all targets and
	   hosts supported by DejaGnu. This global file is identified
	   by setting the environment variable DEJAGNU to the name of
	   the file. If DEJAGNU is set, but the file cannot be
	   located, an error will be raised and runtest will abort.

https://www.gnu.org/software/dejagnu/manual/Customizing-DejaGnu.html

The following seems to always suppress the WARNING:

diff --git a/Makefile b/Makefile
index 1aa208f..2a9898c 100644
--- a/Makefile
+++ b/Makefile
@@ -26,9 +26,14 @@ hello:
 dw2-restrict:
        $(CC) $(TEST_SRC)/dw2-restrict.S -o $@ || touch $@
 
+# On some systems we need to set and export DEJAGNU to suppress
+# WARNING: Couldn't find the global config file.
+DEJAGNU ?= /dev/null
+
 check: dwz $(TEST_EXECS)
        mkdir -p testsuite-bin
        cd testsuite-bin; ln -sf $(PWD)/dwz .
+       export DEJAGNU=$(DEJAGNU); \
        export PATH=$(PWD)/testsuite-bin:$$PATH; export LC_ALL=C; \
        runtest --tool=dwz -srcdir testsuite $(RUNTESTFLAGS)
        rm -Rf testsuite-bin $(TEST_EXECS)

Does that make sense?

Thanks,

Mark

Re: Added a buildbot for dwz

[Tom de Vries]

On 16-03-19 17:31, Mark Wielaard wrote:
> On Sat, Mar 16, 2019 at 04:23:25PM +0100, Tom de Vries wrote:
>>> To celebrate that dwz now has a testsuite I added a buildbot:
>>> https://builder.wildebeest.org/buildbot/#/builders?tags=dwz
>>>
>>
>> I've just pushed a fix for a dejagnu warning on my laptop, and there I
>> see no warnings anymore.
>>
>> However, all builds on the build bot that I checked show:
>> ...
>> WARNING: Couldn't find the global config file.
>> ...
>>
>> I'm not sure if this should be fixed on the buildbot, or in the sources.
> 
> Apparently this comes from not setting the DEJAGNU variable:
> 
> 	   There is an optional global site.exp, containing
> 	   configuration values that apply to DejaGnu
> 	   site-wide. runtest loads these values first. The global
> 	   site.exp contains the default values for all targets and
> 	   hosts supported by DejaGnu. This global file is identified
> 	   by setting the environment variable DEJAGNU to the name of
> 	   the file. If DEJAGNU is set, but the file cannot be
> 	   located, an error will be raised and runtest will abort.
> 
> https://www.gnu.org/software/dejagnu/manual/Customizing-DejaGnu.html
> 
> The following seems to always suppress the WARNING:
> 
> diff --git a/Makefile b/Makefile
> index 1aa208f..2a9898c 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -26,9 +26,14 @@ hello:
>  dw2-restrict:
>         $(CC) $(TEST_SRC)/dw2-restrict.S -o $@ || touch $@
>  
> +# On some systems we need to set and export DEJAGNU to suppress
> +# WARNING: Couldn't find the global config file.
> +DEJAGNU ?= /dev/null
> +
>  check: dwz $(TEST_EXECS)
>         mkdir -p testsuite-bin
>         cd testsuite-bin; ln -sf $(PWD)/dwz .
> +       export DEJAGNU=$(DEJAGNU); \
>         export PATH=$(PWD)/testsuite-bin:$$PATH; export LC_ALL=C; \
>         runtest --tool=dwz -srcdir testsuite $(RUNTESTFLAGS)
>         rm -Rf testsuite-bin $(TEST_EXECS)
> 
> Does that make sense?

Works for me.

Thanks,
- Tom

Re: Added a buildbot for dwz

[Mark Wielaard]

[-- Attachment #1: Type: text/plain, Size: 1170 bytes --]

On Sat, Mar 16, 2019 at 05:37:34PM +0100, Tom de Vries wrote:
> On 16-03-19 17:31, Mark Wielaard wrote:
> > The following seems to always suppress the WARNING:
> > 
> > diff --git a/Makefile b/Makefile
> > index 1aa208f..2a9898c 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -26,9 +26,14 @@ hello:
> >  dw2-restrict:
> >         $(CC) $(TEST_SRC)/dw2-restrict.S -o $@ || touch $@
> >  
> > +# On some systems we need to set and export DEJAGNU to suppress
> > +# WARNING: Couldn't find the global config file.
> > +DEJAGNU ?= /dev/null
> > +
> >  check: dwz $(TEST_EXECS)
> >         mkdir -p testsuite-bin
> >         cd testsuite-bin; ln -sf $(PWD)/dwz .
> > +       export DEJAGNU=$(DEJAGNU); \
> >         export PATH=$(PWD)/testsuite-bin:$$PATH; export LC_ALL=C; \
> >         runtest --tool=dwz -srcdir testsuite $(RUNTESTFLAGS)
> >         rm -Rf testsuite-bin $(TEST_EXECS)
> > 
> > Does that make sense?
> 
> Works for me.

Great. Pushed as attached.
On all buildbot workers make check is warning free.

On some there are some warnings about hashtab.c (implicit-fallthrough).
If that file comes from libiberty maybe we can simply remerge it?

Cheers,

Mark

[-- Attachment #2: 0001-export-DEJAGNU-for-make-check-to-suppress-global-con.patch --]
[-- Type: text/x-diff, Size: 1138 bytes --]

From f31e9dee0a45d392fe08d3441dd64200a5505a05 Mon Sep 17 00:00:00 2001
From: Mark Wielaard <mark@klomp.org>
Date: Sat, 16 Mar 2019 18:38:49 +0100
Subject: [PATCH] export DEJAGNU for make check to suppress global config file
 WARNING.

On some systems we need to set and export DEJAGNU to suppress
WARNING: Couldn't find the global config file.

2019-03-16  Mark Wielaard  <mark@klomp.org>

	* Makefile (DEJAGNU): Optionally set variable.
	(check): export DEJAGNU.
---
 Makefile | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Makefile b/Makefile
index 1aa208f..2ce7b59 100644
--- a/Makefile
+++ b/Makefile
@@ -26,9 +26,14 @@ hello:
 dw2-restrict:
 	$(CC) $(TEST_SRC)/dw2-restrict.S -o $@ || touch $@
 
+# On some systems we need to set and export DEJAGNU to suppress
+# WARNING: Couldn't find the global config file.
+DEJAGNU ?= /dev/null
+
 check: dwz $(TEST_EXECS)
 	mkdir -p testsuite-bin
 	cd testsuite-bin; ln -sf $(PWD)/dwz .
+	export DEJAGNU=$(DEJAGNU); \
 	export PATH=$(PWD)/testsuite-bin:$$PATH; export LC_ALL=C; \
 	runtest --tool=dwz -srcdir testsuite $(RUNTESTFLAGS)
 	rm -Rf testsuite-bin $(TEST_EXECS)
-- 
2.20.1