From: Tom de Vries <tdevries@suse.de>
To: dwz@sourceware.org, jakub@redhat.com
Subject: [committed] Fix verify_sections assert on MIPS
Date: Tue, 01 Jan 2019 00:00:00 -0000 [thread overview]
Message-ID: <20190710071514.GA23652@delia> (raw)
Hi,
The commit 3b335ec "Handle .bss at same offset as .debug_pubnames" introduces
an expression "sh_type & SHT_NOBITS" to test for a NOBITS section, which
should be "sh_type == SHT_NOBITS". Fix it.
Committed to trunk.
Thanks,
- Tom
Fix verify_sections assert on MIPS
2019-07-10 Tom de Vries <tdevries@suse.de>
PR dwz/24783
* dwz.c (write_dso): Test for NOBITS section using
"sh_type == SHT_NOBITS".
---
dwz.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dwz.c b/dwz.c
index 13f67f2..7f6db58 100644
--- a/dwz.c
+++ b/dwz.c
@@ -10691,7 +10691,7 @@ write_dso (DSO *dso, const char *file, struct stat *st)
&& (dso->shdr[j].sh_offset < min_shoff
|| (dso->shdr[j].sh_offset == min_shoff
&& (dso->shdr[j].sh_size == 0
- || dso->shdr[j].sh_type & SHT_NOBITS))))
+ || dso->shdr[j].sh_type == SHT_NOBITS))))
continue;
else if ((dso->shdr[j].sh_flags & SHF_ALLOC) != 0)
{
reply other threads:[~2019-07-10 7:15 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190710071514.GA23652@delia \
--to=tdevries@suse.de \
--cc=dwz@sourceware.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).