* [committed] Fix verify_sections assert on MIPS
@ 2019-01-01 0:00 Tom de Vries
0 siblings, 0 replies; only message in thread
From: Tom de Vries @ 2019-01-01 0:00 UTC (permalink / raw)
To: dwz, jakub
Hi,
The commit 3b335ec "Handle .bss at same offset as .debug_pubnames" introduces
an expression "sh_type & SHT_NOBITS" to test for a NOBITS section, which
should be "sh_type == SHT_NOBITS". Fix it.
Committed to trunk.
Thanks,
- Tom
Fix verify_sections assert on MIPS
2019-07-10 Tom de Vries <tdevries@suse.de>
PR dwz/24783
* dwz.c (write_dso): Test for NOBITS section using
"sh_type == SHT_NOBITS".
---
dwz.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dwz.c b/dwz.c
index 13f67f2..7f6db58 100644
--- a/dwz.c
+++ b/dwz.c
@@ -10691,7 +10691,7 @@ write_dso (DSO *dso, const char *file, struct stat *st)
&& (dso->shdr[j].sh_offset < min_shoff
|| (dso->shdr[j].sh_offset == min_shoff
&& (dso->shdr[j].sh_size == 0
- || dso->shdr[j].sh_type & SHT_NOBITS))))
+ || dso->shdr[j].sh_type == SHT_NOBITS))))
continue;
else if ((dso->shdr[j].sh_flags & SHF_ALLOC) != 0)
{
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2019-07-10 7:15 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-01 0:00 [committed] Fix verify_sections assert on MIPS Tom de Vries
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).