From: Tom de Vries <tdevries@suse.de>
To: dwz@sourceware.org, jakub@redhat.com
Cc: Mark Wielaard <mark@gcc.gnu.org>
Subject: [committed] Don't expect smaller executable when using objcopy and eu-unstrip
Date: Tue, 01 Jan 2019 00:00:00 -0000 [thread overview]
Message-ID: <20190715111302.GA5949@delia> (raw)
Hi,
When testing using gold:
...
$ make CC="gcc -fuse-ld=gold" check
...
we run into:
...
FAIL: testsuite/dwz.tests/objcopy-eu-unstrip.sh
...
The problem is that the unstripped executable is larger than the original one.
This is a known problem, unrelated to dwz (filed as PR elfutils/24809).
Fix this by skipping the smaller-than.sh check when using objcopy and
eu-unstrip.
Committed to trunk.
Thanks,
- Tom
Don't expect smaller executable when using objcopy and eu-unstrip
2019-07-15 Tom de Vries <tdevries@suse.de>
* testsuite/dwz.tests/objcopy-eu-unstrip-multifile.sh: Comment out
smaller-than.sh check.
* testsuite/dwz.tests/objcopy-eu-unstrip.sh: Same.
---
testsuite/dwz.tests/objcopy-eu-unstrip-multifile.sh | 3 ++-
testsuite/dwz.tests/objcopy-eu-unstrip.sh | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/testsuite/dwz.tests/objcopy-eu-unstrip-multifile.sh b/testsuite/dwz.tests/objcopy-eu-unstrip-multifile.sh
index f2ff170..15ed418 100644
--- a/testsuite/dwz.tests/objcopy-eu-unstrip-multifile.sh
+++ b/testsuite/dwz.tests/objcopy-eu-unstrip-multifile.sh
@@ -33,6 +33,7 @@ fi
eu-unstrip 1.stripped 1.debug -o 1.unstripped
-smaller-than.sh 1.unstripped 1
+# An unstripped exec can end up larger than the original (PR elfutils/24809).
+#smaller-than.sh 1.unstripped 1
rm -f 1 1.debug 1.stripped 1.unstripped 3 dwz.err
diff --git a/testsuite/dwz.tests/objcopy-eu-unstrip.sh b/testsuite/dwz.tests/objcopy-eu-unstrip.sh
index abd09ba..18593d0 100644
--- a/testsuite/dwz.tests/objcopy-eu-unstrip.sh
+++ b/testsuite/dwz.tests/objcopy-eu-unstrip.sh
@@ -29,6 +29,7 @@ fi
eu-unstrip 1.stripped 1.debug -o 1.unstripped
-smaller-than.sh 1.unstripped 1
+# An unstripped exec can end up larger than the original (PR elfutils/24809).
+#smaller-than.sh 1.unstripped 1
rm -f 1 1.debug 1.stripped 1.unstripped dwz.err
reply other threads:[~2019-07-15 11:13 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190715111302.GA5949@delia \
--to=tdevries@suse.de \
--cc=dwz@sourceware.org \
--cc=jakub@redhat.com \
--cc=mark@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).