* [committed] Don't expect smaller executable when using objcopy and eu-unstrip
@ 2019-01-01 0:00 Tom de Vries
0 siblings, 0 replies; only message in thread
From: Tom de Vries @ 2019-01-01 0:00 UTC (permalink / raw)
To: dwz, jakub; +Cc: Mark Wielaard
Hi,
When testing using gold:
...
$ make CC="gcc -fuse-ld=gold" check
...
we run into:
...
FAIL: testsuite/dwz.tests/objcopy-eu-unstrip.sh
...
The problem is that the unstripped executable is larger than the original one.
This is a known problem, unrelated to dwz (filed as PR elfutils/24809).
Fix this by skipping the smaller-than.sh check when using objcopy and
eu-unstrip.
Committed to trunk.
Thanks,
- Tom
Don't expect smaller executable when using objcopy and eu-unstrip
2019-07-15 Tom de Vries <tdevries@suse.de>
* testsuite/dwz.tests/objcopy-eu-unstrip-multifile.sh: Comment out
smaller-than.sh check.
* testsuite/dwz.tests/objcopy-eu-unstrip.sh: Same.
---
testsuite/dwz.tests/objcopy-eu-unstrip-multifile.sh | 3 ++-
testsuite/dwz.tests/objcopy-eu-unstrip.sh | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/testsuite/dwz.tests/objcopy-eu-unstrip-multifile.sh b/testsuite/dwz.tests/objcopy-eu-unstrip-multifile.sh
index f2ff170..15ed418 100644
--- a/testsuite/dwz.tests/objcopy-eu-unstrip-multifile.sh
+++ b/testsuite/dwz.tests/objcopy-eu-unstrip-multifile.sh
@@ -33,6 +33,7 @@ fi
eu-unstrip 1.stripped 1.debug -o 1.unstripped
-smaller-than.sh 1.unstripped 1
+# An unstripped exec can end up larger than the original (PR elfutils/24809).
+#smaller-than.sh 1.unstripped 1
rm -f 1 1.debug 1.stripped 1.unstripped 3 dwz.err
diff --git a/testsuite/dwz.tests/objcopy-eu-unstrip.sh b/testsuite/dwz.tests/objcopy-eu-unstrip.sh
index abd09ba..18593d0 100644
--- a/testsuite/dwz.tests/objcopy-eu-unstrip.sh
+++ b/testsuite/dwz.tests/objcopy-eu-unstrip.sh
@@ -29,6 +29,7 @@ fi
eu-unstrip 1.stripped 1.debug -o 1.unstripped
-smaller-than.sh 1.unstripped 1
+# An unstripped exec can end up larger than the original (PR elfutils/24809).
+#smaller-than.sh 1.unstripped 1
rm -f 1 1.debug 1.stripped 1.unstripped dwz.err
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2019-07-15 11:13 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-01 0:00 [committed] Don't expect smaller executable when using objcopy and eu-unstrip Tom de Vries
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).