From: Jakub Jelinek <jakub@redhat.com>
To: Mark Wielaard <mark@klomp.org>
Cc: dwz@sourceware.org
Subject: Re: [PATCH] Don't handle blocks as exprlocs for DWARF version 4 or higher.
Date: Thu, 18 Feb 2021 21:06:35 +0100 [thread overview]
Message-ID: <20210218200635.GN4020736@tucnak> (raw)
In-Reply-To: <990efcdbd7e57467ce989b30b6aea7ae6edf722b.camel@klomp.org>
On Thu, Feb 18, 2021 at 09:01:43PM +0100, Mark Wielaard wrote:
> @@ -6875,6 +6874,30 @@ read_debug_info (DSO *dso, int kind, unsigned int *die_count)
> }
> }
>
> + /* Get length of expr/blocks first. Canonicalize all,
> + except exprloc, to DW_FORM_block1. */
> + switch (form)
> + {
> + case DW_FORM_block1:
> + len = *ptr++;
> + break;
> + case DW_FORM_block2:
> + len = read_16 (ptr);
> + form = DW_FORM_block1;
> + break;
> + case DW_FORM_block4:
> + len = read_32 (ptr);
> + form = DW_FORM_block1;
> + break;
> + case DW_FORM_block:
> + len = read_uleb128 (ptr);
> + form = DW_FORM_block1;
> + break;
> + case DW_FORM_exprloc:
> + len = read_uleb128 (ptr);
> + break;
Can you please add
default:
break;
here?
Otherwise LGTM, thanks.
Jakub
next prev parent reply other threads:[~2021-02-18 20:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-13 22:46 Mark Wielaard
2021-02-18 13:40 ` Mark Wielaard
2021-02-18 14:09 ` Jakub Jelinek
2021-02-18 16:18 ` Mark Wielaard
2021-02-18 16:59 ` Jakub Jelinek
2021-02-18 17:32 ` Jakub Jelinek
2021-02-18 20:01 ` Mark Wielaard
2021-02-18 20:06 ` Jakub Jelinek [this message]
2021-02-18 21:17 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210218200635.GN4020736@tucnak \
--to=jakub@redhat.com \
--cc=dwz@sourceware.org \
--cc=mark@klomp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).