From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: dwz@sourceware.org
Subject: [Bug default/24407] New: comment in partition_dups_1 does not match code
Date: Tue, 01 Jan 2019 00:00:00 -0000 [thread overview]
Message-ID: <bug-24407-11298@http.sourceware.org/bugzilla/> (raw)
https://sourceware.org/bugzilla/show_bug.cgi?id=24407
Bug ID: 24407
Summary: comment in partition_dups_1 does not match code
Product: dwz
Version: unspecified
Status: NEW
Severity: minor
Priority: P2
Component: default
Assignee: nobody at sourceware dot org
Reporter: vries at gcc dot gnu.org
CC: dwz at sourceware dot org
Target Milestone: ---
In partition_dups_1 there's some code:
...
if (second_phase)
{
dw_die_ref next;
for (k = i; k < j; k++)
{
if (arr[k]->die_dup != NULL)
continue;
for (ref = arr[k]; ref; ref = next)
{
dw_cu_ref refcu = die_cu (ref);
next = ref->die_nextdup;
ref->die_dup = NULL;
ref->die_nextdup = NULL;
ref->die_remove = 0;
/* If there are dups within a single CU
(arguably a bug in the DWARF producer),
keep them linked together, but don't link
DIEs across different CUs. */
while (next && refcu == die_cu (next))
{
dw_die_ref cur = next;
next = cur->die_nextdup;
cur->die_dup = ref;
cur->die_nextdup = ref->die_nextdup;
ref->die_nextdup = cur;
}
}
}
}
...
If we have DIEs linked across 2 different CUs, indeed this code breaks the
link.
But if we have DIES linked across 3 different CUs, then this code breaks the
link between the first and the second, but not between the second and the
third.
--
You are receiving this mail because:
You are on the CC list for the bug.
next reply other threads:[~2019-04-01 12:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-01 0:00 vries at gcc dot gnu.org [this message]
2019-01-01 0:00 ` [Bug default/24407] " vries at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-24407-11298@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=dwz@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).