From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: dwz@sourceware.org
Subject: [Bug default/25229] New: Add input verification phase
Date: Tue, 01 Jan 2019 00:00:00 -0000 [thread overview]
Message-ID: <bug-25229-11298@http.sourceware.org/bugzilla/> (raw)
https://sourceware.org/bugzilla/show_bug.cgi?id=25229
Bug ID: 25229
Summary: Add input verification phase
Product: dwz
Version: unspecified
Status: NEW
Severity: enhancement
Priority: P2
Component: default
Assignee: nobody at sourceware dot org
Reporter: vries at gcc dot gnu.org
CC: dwz at sourceware dot org
Target Milestone: ---
I've just committed a fix for PR24169, which makes dwz generate an error for a
certain type of invalid dwarf, in this case an invalid DW_FORM_ref_addr
reference.
The fix follows the just-in-time style of the implementation in the sense that
it generates the error when and where it encounters it, in this case in
write_die.
There are a number of problem with this approach:
- errors are not detected reliably: if dwz decides that it's not a good idea to
optimize the file, it will not report an error, because we never get to
write_die.
- the error may have to be handled in more than one location.
- it may take relatively long before the error is detected.
The fix for this is to have a verify phase (before or in combination with
read_debug_info). Such a phase would obviously add more processing time, so it
would be good to have the user to be able to switch that on or off.
--
You are receiving this mail because:
You are on the CC list for the bug.
next reply other threads:[~2019-11-28 12:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-01 0:00 vries at gcc dot gnu.org [this message]
2019-01-01 0:00 ` [Bug default/25229] " vries at gcc dot gnu.org
2021-03-12 10:56 ` vries at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-25229-11298@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=dwz@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).