* [Bug default/25252] dwz: returns exit status 1, causing FTBFS in deal.ii
2019-01-01 0:00 [Bug default/25252] New: dwz: returns exit status 1, causing FTBFS in deal.ii ginggs at debian dot org
@ 2019-01-01 0:00 ` ginggs at debian dot org
2019-01-01 0:00 ` vries at gcc dot gnu.org
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: ginggs at debian dot org @ 2019-01-01 0:00 UTC (permalink / raw)
To: dwz
https://sourceware.org/bugzilla/show_bug.cgi?id=25252
--- Comment #2 from Graham Inggs <ginggs at debian dot org> ---
> This still exits with 0 on dwz-0.13-branch, so presumably 0.13-3 is
> just some random recent trunk version.
0.13 + cherry-picks from trunk, I believe. Debian's changelog [1] for
reference.
> As for the exit status 1, that's currently the expected result when
> running into the max-die-limit.
Ah, thank you for the explanation. Passing '-L 100000000' to dwz solves my
problem. Is there any reason I should not do this? Or should I try to get
close to the actual number of DIEs?
[1]
https://metadata.ftp-master.debian.org/changelogs/main/d/dwz/unstable_changelog
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 7+ messages in thread* [Bug default/25252] dwz: returns exit status 1, causing FTBFS in deal.ii
2019-01-01 0:00 [Bug default/25252] New: dwz: returns exit status 1, causing FTBFS in deal.ii ginggs at debian dot org
2019-01-01 0:00 ` [Bug default/25252] " ginggs at debian dot org
@ 2019-01-01 0:00 ` vries at gcc dot gnu.org
2019-01-01 0:00 ` vries at gcc dot gnu.org
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: vries at gcc dot gnu.org @ 2019-01-01 0:00 UTC (permalink / raw)
To: dwz
https://sourceware.org/bugzilla/show_bug.cgi?id=25252
--- Comment #3 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Graham Inggs from comment #2)
> > This still exits with 0 on dwz-0.13-branch, so presumably 0.13-3 is
> > just some random recent trunk version.
>
> 0.13 + cherry-picks from trunk, I believe. Debian's changelog [1] for
> reference.
>
Actually, looking at the source, it's an _exact_ match for a recent trunk.
> > As for the exit status 1, that's currently the expected result when
> > running into the max-die-limit.
>
> Ah, thank you for the explanation. Passing '-L 100000000' to dwz solves my
> problem. Is there any reason I should not do this? Or should I try to get
> close to the actual number of DIEs?
Dwz has two limits, which are there for execution time/memory usage reasons.
Anything bigger than the max-die-limit (-L) is not optimized. Increasing that
limit may make things slower, and consume more memory.
Anything bigger than the low-mem-die-limit (-l) is optimized in a slower and
less memory hungry fashion. Also, anything bigger than that is skipped in the
multifile optimization, so the result will be less optimal.
In summary, bump the limits to where they're not hit (on trunk, we have -lnone
and -Lnone for that), and if that is not a problem in terms of execution time
and memory, you're done. If not, than you can tune the limits to reduce
execution time/memory usage to acceptable levels.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 7+ messages in thread* [Bug default/25252] dwz: returns exit status 1, causing FTBFS in deal.ii
2019-01-01 0:00 [Bug default/25252] New: dwz: returns exit status 1, causing FTBFS in deal.ii ginggs at debian dot org
2019-01-01 0:00 ` [Bug default/25252] " ginggs at debian dot org
2019-01-01 0:00 ` vries at gcc dot gnu.org
@ 2019-01-01 0:00 ` vries at gcc dot gnu.org
2021-02-18 23:55 ` mark at klomp dot org
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: vries at gcc dot gnu.org @ 2019-01-01 0:00 UTC (permalink / raw)
To: dwz
https://sourceware.org/bugzilla/show_bug.cgi?id=25252
Tom de Vries <vries at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |UNCONFIRMED
CC| |vries at gcc dot gnu.org
Ever confirmed|1 |0
--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
This still exits with 0 on dwz-0.13-branch, so presumably 0.13-3 is just some
random recent trunk version.
I've bisected this on trunk to commit 48a78ec "Improve handling of running into
both low-mem and max die-limits".
The commit makes the first dwz here return 1, which makes thisret 1, which
makes ret 1, which gets us an exit status of 1:
...
thisret = (low_mem_die_limit == 0
? 2
: dwz (file, NULL, &resa[i - optind],
hardlinks ? resa : NULL, &argv[optind]));
if (thisret == 2)
{
multifile_mode = MULTIFILE_MODE_LOW_MEM;
thisret = dwz (file, NULL, &resa[i - optind],
hardlinks ? resa : NULL, &argv[optind]);
}
else if (resa[i - optind].res == 0)
successcount++;
else if (thisret == 1)
ret = 1;
...
Without the commit, the second dwz returns 1, which is ignored, which is a bug,
which should be fixed by this patch:
...
diff --git a/dwz.c b/dwz.c
index 313c317..af891ab 100644
--- a/dwz.c
+++ b/dwz.c
@@ -13525,7 +13525,7 @@ main (int argc, char *argv[])
}
else if (resa[i - optind].res == 0)
successcount++;
- else if (thisret == 1)
+ if (thisret == 1)
ret = 1;
if (hardlink
&& resa[i - optind].res >= 0
...
As for the exit status 1, that's currently the expected result when running
into the max-die-limit.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 7+ messages in thread* [Bug default/25252] dwz: returns exit status 1, causing FTBFS in deal.ii
2019-01-01 0:00 [Bug default/25252] New: dwz: returns exit status 1, causing FTBFS in deal.ii ginggs at debian dot org
` (2 preceding siblings ...)
2019-01-01 0:00 ` vries at gcc dot gnu.org
@ 2021-02-18 23:55 ` mark at klomp dot org
2021-03-02 12:11 ` vries at gcc dot gnu.org
2021-03-04 9:01 ` vries at gcc dot gnu.org
5 siblings, 0 replies; 7+ messages in thread
From: mark at klomp dot org @ 2021-02-18 23:55 UTC (permalink / raw)
To: dwz
https://sourceware.org/bugzilla/show_bug.cgi?id=25252
Mark Wielaard <mark at klomp dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mark at klomp dot org
--- Comment #4 from Mark Wielaard <mark at klomp dot org> ---
There seems to have been 2 issues here.
One was the "Too many DIEs, not optimizing" which was solved by adding -L
100000000. The downstream debian bug was closed:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=946255
The second was the exit code being wrong. Comment #1 has a patch for that.
Which doesn't seem to have been applied. But I don't know how to trigger that,
so cannot check whether it is still needed.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 7+ messages in thread* [Bug default/25252] dwz: returns exit status 1, causing FTBFS in deal.ii
2019-01-01 0:00 [Bug default/25252] New: dwz: returns exit status 1, causing FTBFS in deal.ii ginggs at debian dot org
` (3 preceding siblings ...)
2021-02-18 23:55 ` mark at klomp dot org
@ 2021-03-02 12:11 ` vries at gcc dot gnu.org
2021-03-04 9:01 ` vries at gcc dot gnu.org
5 siblings, 0 replies; 7+ messages in thread
From: vries at gcc dot gnu.org @ 2021-03-02 12:11 UTC (permalink / raw)
To: dwz
https://sourceware.org/bugzilla/show_bug.cgi?id=25252
--- Comment #5 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Mark Wielaard from comment #4)
> There seems to have been 2 issues here.
>
> One was the "Too many DIEs, not optimizing" which was solved by adding -L
> 100000000. The downstream debian bug was closed:
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=946255
>
Ack.
> The second was the exit code being wrong. Comment #1 has a patch for that.
> Which doesn't seem to have been applied. But I don't know how to trigger
> that, so cannot check whether it is still needed.
Should be fixed by https://sourceware.org/pipermail/dwz/2021q1/001027.html
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 7+ messages in thread* [Bug default/25252] dwz: returns exit status 1, causing FTBFS in deal.ii
2019-01-01 0:00 [Bug default/25252] New: dwz: returns exit status 1, causing FTBFS in deal.ii ginggs at debian dot org
` (4 preceding siblings ...)
2021-03-02 12:11 ` vries at gcc dot gnu.org
@ 2021-03-04 9:01 ` vries at gcc dot gnu.org
5 siblings, 0 replies; 7+ messages in thread
From: vries at gcc dot gnu.org @ 2021-03-04 9:01 UTC (permalink / raw)
To: dwz
https://sourceware.org/bugzilla/show_bug.cgi?id=25252
Tom de Vries <vries at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|UNCONFIRMED |RESOLVED
--- Comment #6 from Tom de Vries <vries at gcc dot gnu.org> ---
Fixed in
https://sourceware.org/git/?p=dwz.git;a=commit;h=05d55402d9f611177f2425e237686c165b635e2d
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 7+ messages in thread