[Bug default/27212] ./dwz: xxx: Invalid DW_AT_decl_file file number 20

["jakub at redhat dot com" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=27212

--- Comment #7 from Jakub Jelinek <jakub at redhat dot com> ---
I understood what you meant with that dance, but as the abbrev is stored first
the value doesn't really make it into the abbrev.  Furthermore, the abbrev
comparison/hashing needs to include those exact values, so they shouldn't be
modified afterwards.
The way (I understand how) build_abbrevs_for_die works is essentially it
creates a new abbrev with the exact values needed in there for each DIE and
then computes hash for that abbrev and looks it up in the hash table, if we
don't already have a dup.
So, if we use the remapped file number in the temporary abbrev's values that
build_abbrevs_for_die is writing, all DIEs (that are otherwise same) that
translate to the same final value will share the same abbrev.

You're right that the update var can be killed, instead case
DW_FORM_implicit_const: can do just j++; continue;
And, we don't have DW_FORM_data8 handled after the lookup in write_die, but
handle it before the lookup.  Strange inconsistency (though it is very unlikely
something would be emitting 64-bit file numbers).

-- 
You are receiving this mail because:
You are on the CC list for the bug.