public inbox for
 help / color / mirror / Atom feed
From: "jakub at redhat dot com" <>
Subject: [Bug default/27212] ./dwz: xxx: Invalid DW_AT_decl_file file number 20
Date: Wed, 20 Jan 2021 21:32:22 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

--- Comment #7 from Jakub Jelinek <jakub at redhat dot com> ---
I understood what you meant with that dance, but as the abbrev is stored first
the value doesn't really make it into the abbrev.  Furthermore, the abbrev
comparison/hashing needs to include those exact values, so they shouldn't be
modified afterwards.
The way (I understand how) build_abbrevs_for_die works is essentially it
creates a new abbrev with the exact values needed in there for each DIE and
then computes hash for that abbrev and looks it up in the hash table, if we
don't already have a dup.
So, if we use the remapped file number in the temporary abbrev's values that
build_abbrevs_for_die is writing, all DIEs (that are otherwise same) that
translate to the same final value will share the same abbrev.

You're right that the update var can be killed, instead case
DW_FORM_implicit_const: can do just j++; continue;
And, we don't have DW_FORM_data8 handled after the lookup in write_die, but
handle it before the lookup.  Strange inconsistency (though it is very unlikely
something would be emitting 64-bit file numbers).

You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2021-01-20 21:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-20  8:38 [Bug default/27212] New: " jakub at redhat dot com
2021-01-20 10:59 ` [Bug default/27212] " mark at klomp dot org
2021-01-20 18:06 ` jakub at redhat dot com
2021-01-20 18:28 ` jakub at redhat dot com
2021-01-20 19:40 ` jakub at redhat dot com
2021-01-20 19:43 ` jakub at redhat dot com
2021-01-20 21:15 ` mark at klomp dot org
2021-01-20 21:32 ` jakub at redhat dot com [this message]
2021-01-20 21:56 ` mark at klomp dot org
2021-01-21  7:58 ` jakub at redhat dot com
2021-02-08 15:51 ` mark at klomp dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).