public inbox for
 help / color / mirror / Atom feed
From: "jakub at redhat dot com" <>
Subject: [Bug default/27212] ./dwz: xxx: Invalid DW_AT_decl_file file number 20
Date: Thu, 21 Jan 2021 07:58:31 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

--- Comment #9 from Jakub Jelinek <jakub at redhat dot com> ---
author  Jakub Jelinek <>        
        Thu, 21 Jan 2021 07:43:08 +0000 (08:43 +0100)
committer       Jakub Jelinek <>        
        Thu, 21 Jan 2021 07:43:08 +0000 (08:43 +0100)
commit  47af8da7c8533924e96d1dbd97625b6a4dc35855
tree    4a924fd99e9ee98dcc4125836309dff06de39b19        tree
parent  40d5efd4edc52a7d2ed02f8400a9beb129053271        commit | diff
Assorted DW_FORM_implicit_const fixes

The problem is I think that write_abbrev is always called before write_info,
and the remapping of the DW_AT_decl_file/DW_AT_call_file DW_FORM_implicit_const
is done only in write_die which is called either recursively or from
write_info/write_types.  Which means the DW_FORM_implicit_const value encoded
in the abbrev was never updated.

Other fixes include hashing the DW_FORM_implicit_const value in checksum_die
and more importantly comparing the values in die_eq_1.

2021-01-21  Jakub Jelinek  <>

PR dwz/27212
PR dwz/27213
* dwz.c (checksum_die): For DW_FORM_implicit_const hash t->values[i].
(die_eq_1): For DW_FORM_implicit_const compare t?->values[?].
(build_abbrevs_for_die): For DW_FORM_implicit_const on DW_AT_*_file
call line_htab_lookup too and store the result into t->values[j].
Otherwise, handle even file ids larger than 32-bit.
(write_die): For DW_FORM_implicit_const on DW_AT_*_file just j++
and continue, don't call line_htab_lookup nor adjust anything.
(alt_clear_dups): Fix function comment.

You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2021-01-21  7:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-20  8:38 [Bug default/27212] New: " jakub at redhat dot com
2021-01-20 10:59 ` [Bug default/27212] " mark at klomp dot org
2021-01-20 18:06 ` jakub at redhat dot com
2021-01-20 18:28 ` jakub at redhat dot com
2021-01-20 19:40 ` jakub at redhat dot com
2021-01-20 19:43 ` jakub at redhat dot com
2021-01-20 21:15 ` mark at klomp dot org
2021-01-20 21:32 ` jakub at redhat dot com
2021-01-20 21:56 ` mark at klomp dot org
2021-01-21  7:58 ` jakub at redhat dot com [this message]
2021-02-08 15:51 ` mark at klomp dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).