public inbox for
 help / color / mirror / Atom feed
From: "mark at klomp dot org" <>
Subject: [Bug default/27212] ./dwz: xxx: Invalid DW_AT_decl_file file number 20
Date: Wed, 20 Jan 2021 21:56:58 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

--- Comment #8 from Mark Wielaard <mark at klomp dot org> ---
(In reply to Jakub Jelinek from comment #7)
> I understood what you meant with that dance, but as the abbrev is stored
> first the value doesn't really make it into the abbrev.  Furthermore, the
> abbrev comparison/hashing needs to include those exact values, so they
> shouldn't be modified afterwards.

O, you are right. So my worries about (and the code workarounds for) changing
an abbrev implicit_const value multiple times were unnecessary. We can do it
simply in build_abbrevs_for_die because the passed in struct abbrev_tag *t is a
"scratch" one setup by the caller(s) to make sure we have something to
construct the new abbrev in. Great. Then I totally agree with this patch.

You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2021-01-20 21:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-20  8:38 [Bug default/27212] New: " jakub at redhat dot com
2021-01-20 10:59 ` [Bug default/27212] " mark at klomp dot org
2021-01-20 18:06 ` jakub at redhat dot com
2021-01-20 18:28 ` jakub at redhat dot com
2021-01-20 19:40 ` jakub at redhat dot com
2021-01-20 19:43 ` jakub at redhat dot com
2021-01-20 21:15 ` mark at klomp dot org
2021-01-20 21:32 ` jakub at redhat dot com
2021-01-20 21:56 ` mark at klomp dot org [this message]
2021-01-21  7:58 ` jakub at redhat dot com
2021-02-08 15:51 ` mark at klomp dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).