From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: dwz@sourceware.org
Subject: [Bug default/27466] New: [dwz] Improve heuristics for odr
Date: Thu, 25 Feb 2021 14:10:30 +0000 [thread overview]
Message-ID: <bug-27466-11298@http.sourceware.org/bugzilla/> (raw)
https://sourceware.org/bugzilla/show_bug.cgi?id=27466
Bug ID: 27466
Summary: [dwz] Improve heuristics for odr
Product: dwz
Version: unspecified
Status: NEW
Severity: enhancement
Priority: P2
Component: default
Assignee: nobody at sourceware dot org
Reporter: vries at gcc dot gnu.org
CC: dwz at sourceware dot org
Target Milestone: ---
In partition_dups_1, we use heuristics to decide whether to convert a partition
into a partial unit.
These heuristics use the number of unique referrer CUs, registered in the cnt
variable.
This cnt is used to compute both:
- the current size of the partition:
"orig_size = size * cnt;"
- to size of imports of partial unit to be created:
"+ (part_lang != 0 ? 0 : import_size * cnt)".
With odr, the duplicate chain is no longer isomorph, and consequently orig_size
cannot any longer be calculated using size * cnt.
Then, the number of unique referrer CUs is the correct number to use for the
number of imports. But due to recent commit "Fix DW_AT_decl_file for odr
", the cnt variable may be lower than the actual number of unique referrer CUs.
--
You are receiving this mail because:
You are on the CC list for the bug.
reply other threads:[~2021-02-25 14:10 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-27466-11298@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=dwz@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).