public inbox for
 help / color / mirror / Atom feed
* [Bug default/27466] New: [dwz] Improve heuristics for odr
@ 2021-02-25 14:10 vries at gcc dot
  0 siblings, 0 replies; only message in thread
From: vries at gcc dot @ 2021-02-25 14:10 UTC (permalink / raw)
  To: dwz

            Bug ID: 27466
           Summary: [dwz] Improve heuristics for odr
           Product: dwz
           Version: unspecified
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: default
          Assignee: nobody at sourceware dot org
          Reporter: vries at gcc dot
                CC: dwz at sourceware dot org
  Target Milestone: ---

In partition_dups_1, we use heuristics to decide whether to convert a partition
into a partial unit.

These heuristics use the number of unique referrer CUs, registered in the cnt

This cnt is used to compute both:
- the current size of the partition:
  "orig_size = size * cnt;" 
- to size of imports of partial unit to be created:
  "+ (part_lang != 0 ? 0 : import_size * cnt)".

With odr, the duplicate chain is no longer isomorph, and consequently orig_size
cannot any longer be calculated using size * cnt.

Then, the number of unique referrer CUs is the correct number to use for the
number of imports.  But due to recent commit "Fix DW_AT_decl_file for odr
", the cnt variable may be lower than the actual number of unique referrer CUs.

You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-02-25 14:10 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-25 14:10 [Bug default/27466] New: [dwz] Improve heuristics for odr vries at gcc dot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).