[Bug default/27466] New: [dwz] Improve heuristics for odr

[Bug default/27466] New: [dwz] Improve heuristics for odr

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=27466

            Bug ID: 27466
           Summary: [dwz] Improve heuristics for odr
           Product: dwz
           Version: unspecified
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: default
          Assignee: nobody at sourceware dot org
          Reporter: vries at gcc dot gnu.org
                CC: dwz at sourceware dot org
  Target Milestone: ---

In partition_dups_1, we use heuristics to decide whether to convert a partition
into a partial unit.

These heuristics use the number of unique referrer CUs, registered in the cnt
variable.

This cnt is used to compute both:
- the current size of the partition:
  "orig_size = size * cnt;" 
- to size of imports of partial unit to be created:
  "+ (part_lang != 0 ? 0 : import_size * cnt)".

With odr, the duplicate chain is no longer isomorph, and consequently orig_size
cannot any longer be calculated using size * cnt.

Then, the number of unique referrer CUs is the correct number to use for the
number of imports.  But due to recent commit "Fix DW_AT_decl_file for odr
", the cnt variable may be lower than the actual number of unique referrer CUs.

-- 
You are receiving this mail because:
You are on the CC list for the bug.