public inbox for ecos-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug 1001359] New: Incorrect include path in SNMP util_funcs.h and config.h
@ 2011-10-11 10:13 bugzilla-daemon
2011-10-11 10:14 ` [Bug 1001359] " bugzilla-daemon
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: bugzilla-daemon @ 2011-10-11 10:13 UTC (permalink / raw)
To: ecos-bugs
Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001359
Summary: Incorrect include path in SNMP util_funcs.h and
config.h
Product: eCos
Version: CVS
Platform: All
OS/Version: All
Status: UNCONFIRMED
Severity: normal
Priority: low
Component: SNMP
AssignedTo: unassigned@bugs.ecos.sourceware.org
ReportedBy: stano@meduna.org
CC: ecos-bugs@ecos.sourceware.org
Class: Advice Request
If the ucd-snmp/mibgroup/util_funcs.h is included by an external code it
includes a file from an invalid location. The same is true for config.h.
See attach for a fix that is enough for my usage - I don't guarantee that it
covers all of the cases.
--
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug 1001359] Incorrect include path in SNMP util_funcs.h and config.h
2011-10-11 10:13 [Bug 1001359] New: Incorrect include path in SNMP util_funcs.h and config.h bugzilla-daemon
@ 2011-10-11 10:14 ` bugzilla-daemon
2011-12-03 20:01 ` bugzilla-daemon
` (2 subsequent siblings)
3 siblings, 0 replies; 9+ messages in thread
From: bugzilla-daemon @ 2011-10-11 10:14 UTC (permalink / raw)
To: ecos-bugs
Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001359
--- Comment #1 from Stanislav Meduna <stano@meduna.org> 2011-10-11 11:14:29 BST ---
Created an attachment (id=1398)
--> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1398)
Patch fixing the issue
--
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug 1001359] Incorrect include path in SNMP util_funcs.h and config.h
2011-10-11 10:13 [Bug 1001359] New: Incorrect include path in SNMP util_funcs.h and config.h bugzilla-daemon
2011-10-11 10:14 ` [Bug 1001359] " bugzilla-daemon
@ 2011-12-03 20:01 ` bugzilla-daemon
2011-12-03 20:11 ` bugzilla-daemon
2014-02-08 23:01 ` bugzilla-daemon
3 siblings, 0 replies; 9+ messages in thread
From: bugzilla-daemon @ 2011-12-03 20:01 UTC (permalink / raw)
To: ecos-bugs
Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001359
--- Comment #2 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-12-03 20:01:30 GMT ---
(In reply to comment #1)
> If the ucd-snmp/mibgroup/util_funcs.h is included by an external code
> it includes a file from an invalid location. The same is true for
> config.h.
>
> See attach for a fix that is enough for my usage - I don't guarantee
> that it covers all of the cases.
Hi Stano,
Thank you for your report.
The ``config.h'' is not part of UCD-SNMP API headers, so, we can fix
that header as you suggested. But, to fix ``util_funcs.h'' is an issue.
As I could see (I tested original ucd-snmp-4.1.2 installation and the
latest ucd-snmp-4.2.7.1 package from net-snmp) normal ucd-snmp install
process does propagate two internal mibgroup's headers (struct.h and
util_funcs.h) under <prefix>/include/ucd-snmp directory. Thus, those
internal headers become the API headers.
Unfortunately, we have not the same headers under eCos <PREFIX>. The
eCos UCD-SNMP header files are all the UCD-SNMP's header files including
internal headers (not only API headers) and their subdirs. I think that
was KIS(s) principle as CDL command ``include_files'' does not let us to
change a structure of the package's headers under eCos <PREFIX>/include.
I think that we have to get all UCD-SNMP API headers in a right place,
i.e. under <PREFIX>/include/ucd-snmp directory and I think we would use
CDL ``make'' command in snmpagent.cdl to copy absent headers there
make -priority=1 {
<PREFIX>/include/ucd-snmp/struct.h : <PACKAGE>/include/mibgroup/struct.h
mkdir -p $(dir $@)
cp -f $^ $(dir $@)
}
and the same command for ``util_funcs.h'' header. Well, it's mine and
may be some one has either another view on your fix or yet another (own)
solution in CDL (I tested above).
Sergei
--
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug 1001359] Incorrect include path in SNMP util_funcs.h and config.h
2011-10-11 10:13 [Bug 1001359] New: Incorrect include path in SNMP util_funcs.h and config.h bugzilla-daemon
2011-10-11 10:14 ` [Bug 1001359] " bugzilla-daemon
2011-12-03 20:01 ` bugzilla-daemon
@ 2011-12-03 20:11 ` bugzilla-daemon
2014-02-08 23:01 ` bugzilla-daemon
3 siblings, 0 replies; 9+ messages in thread
From: bugzilla-daemon @ 2011-12-03 20:11 UTC (permalink / raw)
To: ecos-bugs
Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001359
--- Comment #3 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-12-03 20:11:23 GMT ---
Created an attachment (id=1445)
--> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1445)
original ucd-snmp-4.1.2 installed headers tree
Just to point on installed C-header files from original ucd-snmp-4.1.2 sources.
--
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug 1001359] Incorrect include path in SNMP util_funcs.h and config.h
2011-10-11 10:13 [Bug 1001359] New: Incorrect include path in SNMP util_funcs.h and config.h bugzilla-daemon
` (2 preceding siblings ...)
2011-12-03 20:11 ` bugzilla-daemon
@ 2014-02-08 23:01 ` bugzilla-daemon
3 siblings, 0 replies; 9+ messages in thread
From: bugzilla-daemon @ 2014-02-08 23:01 UTC (permalink / raw)
To: ecos-bugs
Please do not reply to this email, use the link below.
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001359
Mike Jones <mjones@linear.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mjones@linear.com
--- Comment #4 from Mike Jones <mjones@linear.com> ---
I had the same issue and the patch worked for me.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug 1001359] Incorrect include path in SNMP util_funcs.h and config.h
2011-10-11 10:13 [Bug 1001359] New: " bugzilla-daemon
` (2 preceding siblings ...)
2011-12-03 20:11 ` bugzilla-daemon
@ 2014-02-08 23:01 ` bugzilla-daemon
3 siblings, 0 replies; 9+ messages in thread
From: bugzilla-daemon @ 2014-02-08 23:01 UTC (permalink / raw)
To: unassigned
Please do not reply to this email, use the link below.
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001359
Mike Jones <mjones@linear.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mjones@linear.com
--- Comment #4 from Mike Jones <mjones@linear.com> ---
I had the same issue and the patch worked for me.
--
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug 1001359] Incorrect include path in SNMP util_funcs.h and config.h
2011-10-11 10:13 [Bug 1001359] New: " bugzilla-daemon
2011-10-11 10:14 ` [Bug 1001359] " bugzilla-daemon
2011-12-03 20:01 ` bugzilla-daemon
@ 2011-12-03 20:11 ` bugzilla-daemon
2014-02-08 23:01 ` bugzilla-daemon
3 siblings, 0 replies; 9+ messages in thread
From: bugzilla-daemon @ 2011-12-03 20:11 UTC (permalink / raw)
To: unassigned
Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001359
--- Comment #3 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-12-03 20:11:23 GMT ---
Created an attachment (id=1445)
--> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1445)
original ucd-snmp-4.1.2 installed headers tree
Just to point on installed C-header files from original ucd-snmp-4.1.2 sources.
--
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug 1001359] Incorrect include path in SNMP util_funcs.h and config.h
2011-10-11 10:13 [Bug 1001359] New: " bugzilla-daemon
2011-10-11 10:14 ` [Bug 1001359] " bugzilla-daemon
@ 2011-12-03 20:01 ` bugzilla-daemon
2011-12-03 20:11 ` bugzilla-daemon
2014-02-08 23:01 ` bugzilla-daemon
3 siblings, 0 replies; 9+ messages in thread
From: bugzilla-daemon @ 2011-12-03 20:01 UTC (permalink / raw)
To: unassigned
Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001359
--- Comment #2 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-12-03 20:01:30 GMT ---
(In reply to comment #1)
> If the ucd-snmp/mibgroup/util_funcs.h is included by an external code
> it includes a file from an invalid location. The same is true for
> config.h.
>
> See attach for a fix that is enough for my usage - I don't guarantee
> that it covers all of the cases.
Hi Stano,
Thank you for your report.
The ``config.h'' is not part of UCD-SNMP API headers, so, we can fix
that header as you suggested. But, to fix ``util_funcs.h'' is an issue.
As I could see (I tested original ucd-snmp-4.1.2 installation and the
latest ucd-snmp-4.2.7.1 package from net-snmp) normal ucd-snmp install
process does propagate two internal mibgroup's headers (struct.h and
util_funcs.h) under <prefix>/include/ucd-snmp directory. Thus, those
internal headers become the API headers.
Unfortunately, we have not the same headers under eCos <PREFIX>. The
eCos UCD-SNMP header files are all the UCD-SNMP's header files including
internal headers (not only API headers) and their subdirs. I think that
was KIS(s) principle as CDL command ``include_files'' does not let us to
change a structure of the package's headers under eCos <PREFIX>/include.
I think that we have to get all UCD-SNMP API headers in a right place,
i.e. under <PREFIX>/include/ucd-snmp directory and I think we would use
CDL ``make'' command in snmpagent.cdl to copy absent headers there
make -priority=1 {
<PREFIX>/include/ucd-snmp/struct.h : <PACKAGE>/include/mibgroup/struct.h
mkdir -p $(dir $@)
cp -f $^ $(dir $@)
}
and the same command for ``util_funcs.h'' header. Well, it's mine and
may be some one has either another view on your fix or yet another (own)
solution in CDL (I tested above).
Sergei
--
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug 1001359] Incorrect include path in SNMP util_funcs.h and config.h
2011-10-11 10:13 [Bug 1001359] New: " bugzilla-daemon
@ 2011-10-11 10:14 ` bugzilla-daemon
2011-12-03 20:01 ` bugzilla-daemon
` (2 subsequent siblings)
3 siblings, 0 replies; 9+ messages in thread
From: bugzilla-daemon @ 2011-10-11 10:14 UTC (permalink / raw)
To: unassigned
Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001359
--- Comment #1 from Stanislav Meduna <stano@meduna.org> 2011-10-11 11:14:29 BST ---
Created an attachment (id=1398)
--> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1398)
Patch fixing the issue
--
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2014-02-08 23:01 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-10-11 10:13 [Bug 1001359] New: Incorrect include path in SNMP util_funcs.h and config.h bugzilla-daemon
2011-10-11 10:14 ` [Bug 1001359] " bugzilla-daemon
2011-12-03 20:01 ` bugzilla-daemon
2011-12-03 20:11 ` bugzilla-daemon
2014-02-08 23:01 ` bugzilla-daemon
2011-10-11 10:13 [Bug 1001359] New: " bugzilla-daemon
2011-10-11 10:14 ` [Bug 1001359] " bugzilla-daemon
2011-12-03 20:01 ` bugzilla-daemon
2011-12-03 20:11 ` bugzilla-daemon
2014-02-08 23:01 ` bugzilla-daemon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).