public inbox for ecos-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug 1001665] New: Typo in hal_stm32_dma_isr return value
@ 2012-09-03 14:28 bugzilla-daemon
  0 siblings, 0 replies; 2+ messages in thread
From: bugzilla-daemon @ 2012-09-03 14:28 UTC (permalink / raw)
  To: ecos-bugs

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001665

           Summary: Typo in hal_stm32_dma_isr return value
           Product: eCos
           Version: CVS
          Platform: stm32e_eval (ST STM3210E EVAL board)
        OS/Version: Cortex-M
            Status: UNCONFIRMED
          Severity: normal
          Priority: low
         Component: HAL
        AssignedTo: unassigned@bugs.ecos.sourceware.org
        ReportedBy: alan.bowman@datong.co.uk
                CC: ecos-bugs@ecos.sourceware.org
             Class: Advice Request


The variable "ret" is initialised with CYG_ISR_HANDLED, and the used as the
return value.  It looks like there are no circumstances where this ISR does not
handle this vector.  However, ret is modified to CYG_ISR_CALL_DSR when the if
statement is followed.

I think that CYG_ISR_CALL_DSR should have been OR'd in to ret.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [Bug 1001665] New: Typo in hal_stm32_dma_isr return value
@ 2012-09-03 14:28 bugzilla-daemon
  0 siblings, 0 replies; 2+ messages in thread
From: bugzilla-daemon @ 2012-09-03 14:28 UTC (permalink / raw)
  To: unassigned

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001665

           Summary: Typo in hal_stm32_dma_isr return value
           Product: eCos
           Version: CVS
          Platform: stm32e_eval (ST STM3210E EVAL board)
        OS/Version: Cortex-M
            Status: UNCONFIRMED
          Severity: normal
          Priority: low
         Component: HAL
        AssignedTo: unassigned@bugs.ecos.sourceware.org
        ReportedBy: alan.bowman@datong.co.uk
                CC: ecos-bugs@ecos.sourceware.org
             Class: Advice Request


The variable "ret" is initialised with CYG_ISR_HANDLED, and the used as the
return value.  It looks like there are no circumstances where this ISR does not
handle this vector.  However, ret is modified to CYG_ISR_CALL_DSR when the if
statement is followed.

I think that CYG_ISR_CALL_DSR should have been OR'd in to ret.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-09-03 14:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-03 14:28 [Bug 1001665] New: Typo in hal_stm32_dma_isr return value bugzilla-daemon
  -- strict thread matches above, loose matches on Subject: below --
2012-09-03 14:28 bugzilla-daemon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).