From: Andrew Lunn <andrew@lunn.ch>
To: Jim Seymour <ecosjim@cipher.com>
Cc: ecos-discuss@ecos.sourceware.org
Subject: Re: [ECOS] AT91 Serial Receive: asserts when buffer fills up
Date: Thu, 31 May 2007 23:32:00 -0000 [thread overview]
Message-ID: <20070531231709.GC5944@lunn.ch> (raw)
In-Reply-To: <465F4A25.8070407@cipher.com>
On Thu, May 31, 2007 at 03:20:21PM -0700, Jim Seymour wrote:
> In the serial DSR in at91_serial.c, there is a CYG_FAIL() macro if the
> receive buffer fills up. (Line #612)
>
> Is this appropriate? We like to run with asserts turned on (at least
> during development), but in our application, overflowing the receive
> buffer is not that big of a deal.
>
> It appears that all the other serial drivers quietly throw away
> characters if their receive buffer is full. Any complaints if I submit
> a patch to do the same in the AT91 driver?
"all other" equates to just the sh/scif driver. At the moment there
are only two drivers to do block transfers, the AT91 being the other.
Removing the CYG_FAIL is O.K.
Andrew
--
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss
prev parent reply other threads:[~2007-05-31 23:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-31 23:17 Jim Seymour
2007-05-31 23:32 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070531231709.GC5944@lunn.ch \
--to=andrew@lunn.ch \
--cc=ecos-discuss@ecos.sourceware.org \
--cc=ecosjim@cipher.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).