[ECOS] arm SPI1 cdl bugfix, new variant support

[ECOS] arm SPI1 cdl bugfix, new variant support

[Szentirmai Gergely]

Hello

I have discovered an error in spi_at91.cdl

    cdl_option CYGHWR_DEVS_SPI_ARM_AT91_BUS1 {
    active_if     CYGINT_DEVS_SPI_ARM_AT_HAS_BUS1
        display       "Enable support for SPI bus 1"
        flavor        bool
        default_value 0
        description   "Enable this option to add support for the second
                   SPI peripheral. The most AT91 devices only have one bus"
    }


CYGINT_DEVS_SPI_ARM_AT_HAS_BUS1 is wrong, CYGINT_DEVS_SPI_ARM_HAS_BUS1 
is the right value.

And I added support for SAM7A3, and definitions for the MCI interface. 
What is the right way to post my changes?

Thanks!
Gergely Szentirmai

-- 
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss

[ECOS] Re: arm SPI1 cdl bugfix, new variant support

[John Dallaway]

Hi Szentirmai

Szentirmai Gergely wrote:

> I have discovered an error in spi_at91.cdl
> 
>    cdl_option CYGHWR_DEVS_SPI_ARM_AT91_BUS1 {
>    active_if     CYGINT_DEVS_SPI_ARM_AT_HAS_BUS1
>        display       "Enable support for SPI bus 1"
>        flavor        bool
>        default_value 0
>        description   "Enable this option to add support for the second
>                   SPI peripheral. The most AT91 devices only have one bus"
>    }
> 
> CYGINT_DEVS_SPI_ARM_AT_HAS_BUS1 is wrong, CYGINT_DEVS_SPI_ARM_HAS_BUS1
> is the right value.

See Bugzilla 1000737:

  http://bugs.ecos.sourceware.org/show_bug.cgi?id=1000737

> And I added support for SAM7A3, and definitions for the MCI interface.
> What is the right way to post my changes?

Contributions are best made as attachments in Bugzilla. Create a new
Bugzilla report and set the component field to "Patches and contributions".

For changes to existing code, please generate a patch against the latest
sources in our CVS repository using "cvs -q diff -U5". For new files and
packages, simply generate a compressed tarball (.tar.bz2).

The eCos maintainers will then review your contribution.

Thank you

John Dallaway

-- 
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss

Re: [ECOS] arm SPI1 cdl bugfix, new variant support - correction

[Szentirmai Gergely]

Just a correction:
CYGINT_DEVS_SPI_ARM_AT91_HAS_BUS1  is the right one

Szentirmai Gergely Ă­rta:
> Hello
>
> I have discovered an error in spi_at91.cdl
>
>    cdl_option CYGHWR_DEVS_SPI_ARM_AT91_BUS1 {
>    active_if     CYGINT_DEVS_SPI_ARM_AT_HAS_BUS1
>        display       "Enable support for SPI bus 1"
>        flavor        bool
>        default_value 0
>        description   "Enable this option to add support for the second
>                   SPI peripheral. The most AT91 devices only have one 
> bus"
>    }
>
>
> CYGINT_DEVS_SPI_ARM_AT_HAS_BUS1 is wrong, CYGINT_DEVS_SPI_ARM_HAS_BUS1 
> is the right value.
>
> And I added support for SAM7A3, and definitions for the MCI interface. 
> What is the right way to post my changes?
>
> Thanks!
> Gergely Szentirmai
>

-- 
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss

Re: [ECOS] Re: arm SPI1 cdl bugfix, new variant support

[John Dallaway]

Hi Szentirmai

Szentirmai Gergely wrote:

> I have downloaded ecos 3.0 final from the ftp. How can I check it out
> from the CVS (to make the diff)?
> I use the anon cvs, but the sources are from ecos 2.0 I think.
> I used to checkout with this command:
> cvs -z3 -d :pserver:anoncvs@ecos.sourceware.org:/cvs/ecos co -P ecos

You can update your checkout to the latest eCos sources in CVS using:

  cd ecos/packages/
  cvs -q up -d -P

or you can checkout the latest sources into a new directory using the
same command you used previously.

John Dallaway

-- 
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss

Re: [ECOS] Re: arm SPI1 cdl bugfix, new variant support

[Peter Niebert]

Just for the record, I was very impressed by the reactivity of the  
eCos team. I submitted the bug report and three hours later the fix  
was in the cvs. Keep up the good work :-)

Cheers,

-- Peter Niebert

Le 8 avr. 09 à 16:38, John Dallaway a écrit :

> Hi Szentirmai
>
> Szentirmai Gergely wrote:
>
>> I have downloaded ecos 3.0 final from the ftp. How can I check it out
>> from the CVS (to make the diff)?
>> I use the anon cvs, but the sources are from ecos 2.0 I think.
>> I used to checkout with this command:
>> cvs -z3 -d :pserver:anoncvs@ecos.sourceware.org:/cvs/ecos co -P ecos
>
> You can update your checkout to the latest eCos sources in CVS using:
>
>  cd ecos/packages/
>  cvs -q up -d -P
>
> or you can checkout the latest sources into a new directory using the
> same command you used previously.
>
> John Dallaway
>
> -- 
> Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
> and search the list archive: http://ecos.sourceware.org/ml/ecos- 
> discuss
>


--
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss

[ECOS] Re: arm SPI1 cdl bugfix, new variant support

[vibisreenivasan]

hi John,

On Wed, 2009-04-08 at 14:39 +0100, John Dallaway wrote:
> Hi Szentirmai
> 
> Szentirmai Gergely wrote:
> 
> > I have discovered an error in spi_at91.cdl
> >
> >    cdl_option CYGHWR_DEVS_SPI_ARM_AT91_BUS1 {
> >    active_if     CYGINT_DEVS_SPI_ARM_AT_HAS_BUS1
> >        display       "Enable support for SPI bus 1"
> >        flavor        bool
> >        default_value 0
> >        description   "Enable this option to add support for the
second
> >                   SPI peripheral. The most AT91 devices only have
one bus"
> >    }
> >
> > CYGINT_DEVS_SPI_ARM_AT_HAS_BUS1 is wrong,
CYGINT_DEVS_SPI_ARM_HAS_BUS1
> > is the right value.
> 
> See Bugzilla 1000737:
> 
>   http://bugs.ecos.sourceware.org/show_bug.cgi?id=1000737
> 
> > And I added support for SAM7A3, and definitions for the MCI
interface.
> > What is the right way to post my changes?
> 
> Contributions are best made as attachments in Bugzilla. Create a new
> Bugzilla report and set the component field to "Patches and
contributions".
> 

Cant we use ecos-patches mailing list to send patches.
In fact i have send a patch for adding I2C support for AT91 H/W.
But i didnt get any review comments from maintainers.

> For changes to existing code, please generate a patch against the
latest
> sources in our CVS repository using "cvs -q diff -U5". For new files
and
> packages, simply generate a compressed tarball (.tar.bz2).
> 
> The eCos maintainers will then review your contribution.
> 
> Thank you
> 
> John Dallaway
Thanks & regards
vibi




-- 
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss

[ECOS] Re: arm SPI1 cdl bugfix, new variant support

[John Dallaway]

vibisreenivasan wrote:

> On Wed, 2009-04-08 at 14:39 +0100, John Dallaway wrote:
> 
>> Szentirmai Gergely wrote:
>>
>>> What is the right way to post my changes?
>> 
>> Contributions are best made as attachments in Bugzilla. Create a new
>> Bugzilla report and set the component field to "Patches and
>> contributions".
> 
> Cant we use ecos-patches mailing list to send patches.
> In fact i have send a patch for adding I2C support for AT91 H/W.

I prefer using Bugzilla because it keeps all correspondence in one
place, but posting contributions to the ecos-patches list should also
work. One of the maintainers will review your patch in due course.

Thank you for your contribution

John Dallaway

-- 
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss

Re: [ECOS] Re: arm SPI1 cdl bugfix, new variant support

[Szentirmai Gergely]

Hello

I wanted to create an account on bugzilla, but the reg mail has not 
arrived. Theres a mail address, where you can ask the admin, but it was 
unable to deliver my mail to the admin:

<bugzilla@ecoscentric.com> (expanded from <bugzilla-admin@ecoscentric.com>):
     host mail.ecoscentric.com[/var/lib/imap/socket/lmtp] said: 550-Mailbox
     unknown.  Either there is no mailbox associated with this 550-name 
or you
     do not have authorization to see it. 550 5.1.1 User unknown (in 
reply to
     RCPT TO command)

So, what's next? :D

Gergely Szentirmai


John Dallaway írta:
> vibisreenivasan wrote:
> 
>> On Wed, 2009-04-08 at 14:39 +0100, John Dallaway wrote:
>>
>>> Szentirmai Gergely wrote:
>>>
>>>> What is the right way to post my changes?
>>> Contributions are best made as attachments in Bugzilla. Create a new
>>> Bugzilla report and set the component field to "Patches and
>>> contributions".
>> Cant we use ecos-patches mailing list to send patches.
>> In fact i have send a patch for adding I2C support for AT91 H/W.
> 
> I prefer using Bugzilla because it keeps all correspondence in one
> place, but posting contributions to the ecos-patches list should also
> work. One of the maintainers will review your patch in due course.
> 
> Thank you for your contribution
> 
> John Dallaway
> 

-- 
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss

[ECOS] Re: arm SPI1 cdl bugfix, new variant support

[John Dallaway]

Szentirmai Gergely wrote:

> I wanted to create an account on bugzilla, but the reg mail has not
> arrived. Theres a mail address, where you can ask the admin, but it was
> unable to deliver my mail to the admin:
> 
> <bugzilla@ecoscentric.com> (expanded from
> <bugzilla-admin@ecoscentric.com>):
>     host mail.ecoscentric.com[/var/lib/imap/socket/lmtp] said: 550-Mailbox
>     unknown.  Either there is no mailbox associated with this 550-name
> or you
>     do not have authorization to see it. 550 5.1.1 User unknown (in
> reply to
>     RCPT TO command)
> 
> So, what's next? :D

Automated e-mails from Bugzilla might be blocked by certain spam
filters. Try registering for Bugzilla using another e-mail address if
you have one. Otherwise, e-mail to sysadmin@ecoscentric.com should reach
someone who can help.

John Dallaway

-- 
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss