public inbox for
 help / color / mirror / Atom feed
* [Issue 1001187] New port - HAL: Freescale Kinetis variant, TWR-K60N512, TWR-K40X256 plf; Devs: Freescale UART and ENET (Ethernet)
       [not found] <>
@ 2011-10-17  3:23 ` bugzilla-daemon
  0 siblings, 0 replies; only message in thread
From: bugzilla-daemon @ 2011-10-17  3:23 UTC (permalink / raw)
  To: ecos-patches

Please do not reply to this email. Use the web interface provided at:

Jonathan Larmour <> changed:

           What    |Removed                     |Added
                 CC|                            |

--- Comment #20 from Jonathan Larmour <> 2011-10-17 04:22:32 BST ---
As per direct mail, here's a few comments, although I haven't done what I'd
call a full review:

- I'll just mention that if extra TTYs are justified, then you should just

- "familly" should be spelt "family", and "acces" -> "access"

- CDL display names shouldn't really end in full-stops ("."). The best way to
decide what to use for display names is to think of what would be best in the
graphical configuration tool - even if you, like many maintainers, don't use
it, lots of eCos users do.

- Various components which are "flavor none" should also have "no_define".

- The CYGPKG_HAL_CORTEXM_KINETIS .cdl file is quite big - perhaps the
components related to clocking could be split off into a separate file, and

- This bit in hal_diag.c:

I think you originally meant to begin that with:

But given the CDL you can probably just use:

Nothing else leapt out at me. It seems a very good quality patch from what I
can tell.


Configure issuemail:
------- You are receiving this mail because: -------
You are on the CC list for the issue.

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2011-10-17  3:23 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <>
2011-10-17  3:23 ` [Issue 1001187] New port - HAL: Freescale Kinetis variant, TWR-K60N512, TWR-K40X256 plf; Devs: Freescale UART and ENET (Ethernet) bugzilla-daemon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).