[Bug 1000910] New port: Ethernet over SPI driver for ENC424J600

[bugzilla-daemon@bugs.ecos.sourceware.org]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1000910

Ilija Stanislevik <ilijas@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1131|0                           |1
        is obsolete|                            |

--- Comment #13 from Ilija Stanislevik <ilijas@siva.com.mk> 2011-10-27 15:22:27 BST ---
Created an attachment (id=1420)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1420)
Updated enc424j600 Ethernet driver

(In reply to comment #12)

> >> - A trivial thing that would be nice: CYGNUM_DEVS_ETH_ENC424J600_FLOWC has
> >> values which could be friendlier when e.g. presented in the configuration tool.
> >> Any chance they could actually be just None and Auto? If you wanted, some
> >> #ifdef magic could still translate them if you preferred.
> >
> > There is a possibility for third option, besides no-flow-control and
> > on-chip-flow-control, that is in-driver-flow-control. I did not implement it,
> > but I think that it might be implemented in future. So, I decided to keep
> > CYGNUM_DEVS_ETH_ENC424J600_FLOWC unchanged.
> 
> What I was suggesting wouldn't change that. It would just mean that in that
> case the legal_values now would be { "None" "On-chip" } and in future you could
> add "In-driver" to that.
> 
> I'm just noticing that that option should probably be CYGSEM_...
> 
> If you want to keep the rest of the code the same as it is now, you could add
> this in a header:
> #if (CYGSEM_DEVS_ETH_ENC424J600_FLOWC == On-chip)
> # define CYGSEM_DEVS_ETH_ENC424J600_FLOWC_ONCHIP_AUTO_FC
> #endif

I see. I've made changes as per your suggestion, except for OnChip instead of
On-chip. I didn't find a way to persuade the preprocessor not to take the
hyphen for a minus sign.

I've also changed the legal_values of some other components into, as I hope,
better readable ones.

I've changed the way the interrupt priority is specified. Now it can be
specified from HAL. If not, the user can specify it directly in driver, just as
it is the case with interrupt vector.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.