public inbox for
 help / color / mirror / Atom feed
Subject: [Bug 1000910] New port: Ethernet over SPI driver for ENC424J600
Date: Fri, 04 May 2012 16:36:00 -0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Please do not reply to this email. Use the web interface provided at:

--- Comment #21 from Jonathan Larmour <> 2012-05-04 17:35:48 BST ---
I have made a bunch of cosmetic updates and applied the patch, thanks! I will
attach the updated version of the patch, along with the updates themselves. A
lot of them were just whitespace changes, most especially in the CDL file. It
now conforms to our existing practice much better, and in future you may want
to watch out for the sort of things I changed if you submit patches in future.
There are a few other textual changes too, and some fixes of changing things
like cdl_components which should really be cdl_options. But nothing of great

Note, despite the earlier discussion, I have in the end changed the description
of CYGHWR_HAL_CORTEXM_STM32_SPIETH_CONTROLLER because I realised that in the
configuration tool, if the CYGPKG_DEVS_ETH_ENC424J600 package is not loaded,
the package will be displayed at the top level, albeit inactive. With a title
of just "STM3210E HAL resources", this might confuse some people.

Configure bugmail:
------- You are receiving this mail because: -------
You are on the CC list for the bug.

  parent reply	other threads:[~2012-05-04 16:36 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <>
2011-02-17  9:49 ` bugzilla-daemon
2011-02-17 10:43 ` bugzilla-daemon
2011-10-27 14:22 ` bugzilla-daemon
2011-10-27 14:41 ` bugzilla-daemon
2011-10-27 14:43 ` bugzilla-daemon
2012-04-02 20:21 ` bugzilla-daemon
2012-04-05  6:22 ` bugzilla-daemon
2012-04-05 15:52 ` bugzilla-daemon
2012-04-20  8:00 ` bugzilla-daemon
2012-04-20  8:07 ` bugzilla-daemon
2012-05-04 16:36 ` bugzilla-daemon [this message]
2012-05-04 16:37 ` bugzilla-daemon
2012-05-04 16:37 ` bugzilla-daemon
2012-05-04 16:38 ` bugzilla-daemon
2012-05-04 16:38 ` bugzilla-daemon
2012-05-04 16:39 ` bugzilla-daemon
2012-05-04 16:40 ` bugzilla-daemon
2012-05-07 16:43 ` bugzilla-daemon
2012-05-10 15:48 ` bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).