[Bug 1001550] STM32 F2 and STM3220G-EVAL / STM3240G-EVAL contribution from eCosCentric

[bugzilla-daemon@bugs.ecos.sourceware.org]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001550

John Dallaway <john@dallaway.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
                 CC|                            |john@dallaway.org.uk
         Resolution|NEXTRELEASE                 |

--- Comment #9 from John Dallaway <john@dallaway.org.uk> 2012-04-01 20:41:08 BST ---
Jifl, great to see this contribution!

Some initial comments/queries based on a quick scan of the patches:

* An earlier patch to the STM32 serial driver for bug #1001068 appears to have
been reversed by your patch. Can you reinstate this please?

* Some of the changes listed in the STM3210E-EVAL platform HAL ChangeLog do not
appear to be present in the source patch (eg the .ldi file changes). Can you
check that the various ChangeLogs provide an accurate reflection of the changes
committed please? Ref:

http://bugs.ecos.sourceware.org/attachment.cgi?id=1684&action=diff

* The ecos.db patch lists the STM32 ethernet and watchdog packages for the new
targets and some relevant register definitions are provided at the HAL level
but I don't see the packages in the CVS commit. Ref:

http://bugs.ecos.sourceware.org/attachment.cgi?id=1683&action=diff#ecos.db_sec2

* The "set_value" keyword in ecos.db was introduced as a quick hack for use
within the Red Hat test farm and was never intended to be used elsewhere.
set_value will provide a user_value for the specified CDL item which can
therefore be inadvertently changed using the "restore defaults" action in
configtool. I would really like to consider the use of "set_value" to be
deprecated. It should always be possible to use a separate tiny CDL-only
package to achieve the same effect. Are you OK with this?

Finally, are you able to confirm that the code you have checked in has been
tested (eCos and RedBoot run-time) in the context of the eCos CVS HEAD? This is
a substantial patch and I'm just concerned that we don't destabilise the
existing STM32 support.

Thanks

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.