[Bug 1001550] STM32 F2 and STM3220G-EVAL / STM3240G-EVAL contribution from eCosCentric

[bugzilla-daemon@bugs.ecos.sourceware.org]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001550

--- Comment #13 from Jonathan Larmour <jifl@ecoscentric.com> 2012-04-02 16:55:32 BST ---
(In reply to comment #10)
> Hi Jifl, can you integrate this contribution with the existing STM32
> contribution in bug #1001219 ? It seems that the Jerzy's contribution should
> really have been checked in first to avoid conflicts.

As far as I knew, that change was still work in progress, whereas this
contribution was complete and finished. Were it otherwise, then I would expect
Jerzy's contribution to have been committed, and at that point yes merging may
have had to be considered for some portions. However looking at Jerzy's
contribution, the STM32 variant changes in the eCosCentric contribution
completely subsume and obsolete what Jerzy did, given this needs to provide
both connectivity line *and* F2/F4 processor support, which changes clocking
and pin mapping properties significantly, so the result would still have been
something that looks identical or near-identical to this contribution.

As for the Ethernet, it's up to Jerzy if he wants to use the definitions
provided, or provide his own alternative in var_io_eth.h - at least a separate
file keeps it all self-contained (var_io.h was getting too big to be
navigable). All I would say is that eCosCentric's driver has undergone
extensive testing using these definitions, so they are "known good", and has
been used on multiple boards, and include necessary changed definitions for the
F2/F4 which Jerzy's obviously wouldn't. And he will probably find the majority
correspond exactly to what he's already got anyway since both the names and
values essentially come from ST anyway.

But yes, since an ethernet driver is not included in this contribution, Jerzy
is free to use or ignore these definitions. They're there to be helpful, not to
be an obstacle.

Jifl

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.