Patch fixes bad "requires" constraint in io_flash.cdl

Patch fixes bad "requires" constraint in io_flash.cdl

[Daniel Helgason]

[-- Attachment #1: Type: text/plain, Size: 396 bytes --]

Attached is a patch to

ecos/packages/io/flash/current/cdl/io_flash.cdl

to fix bad "requires" constraint on CYGNUM_IO_FLASH_BLOCK_OFFSET_n in
io_flash.cdl file.

In the current version, it is not possible to position a block device at
offset 0 in the flash using "Static configuration via offset" option.

-- 
+---------------------------------------------
| Daniel Helgason <dhelgason@shaw.ca>

[-- Attachment #2: io_flash.cdl.diff --]
[-- Type: text/x-patch, Size: 821 bytes --]

--- a/packages/io/flash/current/cdl/io_flash.cdl
+++ b/packages/io/flash/current/cdl/io_flash.cdl
@@ -219,7 +219,7 @@
         default_value    1
         compile          legacy_api.c
         description      "
-            Provide an implementation of the lagacy user API. This is mapped 
+            Provide an implementation of the legacy user API. This is mapped
             onto the new API via a small layer of code"
     }
         
@@ -283,7 +283,7 @@
 			display         "Length"
 			flavor          data
 			default_value   0
-			requires        0 != CYGNUM_IO_FLASH_BLOCK_OFFSET_$::dev
+			requires        0 != CYGNUM_IO_FLASH_BLOCK_LENGTH_$::dev
 			description     "
                             This gives the length of the region of flash given over
                             to this block device."

Re: Patch fixes bad "requires" constraint in io_flash.cdl

[Sergei Gavrikov]

Daniel Helgason wrote:

> Attached is a patch to
>
> ecos/packages/io/flash/current/cdl/io_flash.cdl
>
> to fix bad "requires" constraint on CYGNUM_IO_FLASH_BLOCK_OFFSET_n in
> io_flash.cdl file.
>
> In the current version, it is not possible to position a block device at
> offset 0 in the flash using "Static configuration via offset" option.

Hi Daniel,

Thank you for this catch. Could you provide a ChangeLog entry also? If you 
used HG you can regenerate diff as `hg diff -b' to trim the ws difference.

Sergei

Re: Patch fixes bad "requires" constraint in io_flash.cdl

[Daniel Helgason]

[-- Attachment #1: Type: text/plain, Size: 891 bytes --]

On Thu, 2010-03-25 at 22:21 +0200, Sergei Gavrikov wrote:
> Daniel Helgason wrote:
> 
> > Attached is a patch to
> >
> > ecos/packages/io/flash/current/cdl/io_flash.cdl
> >
> > to fix bad "requires" constraint on CYGNUM_IO_FLASH_BLOCK_OFFSET_n in
> > io_flash.cdl file.
> >
> > In the current version, it is not possible to position a block device at
> > offset 0 in the flash using "Static configuration via offset" option.
> 
> Hi Daniel,
> 
> Thank you for this catch. Could you provide a ChangeLog entry also? If you 
> used HG you can regenerate diff as `hg diff -b' to trim the ws difference.
> ...

Resubmitting original io_flash.cdl patch (unchanged) and also attached
new patch to

ecos/packages/io/flash/current/ChangeLog

to add info wrt io_flash.cdl patch as requested by Sergei Gavrikov.

-- 
+---------------------------------------------
| Daniel Helgason <dhelgason@shaw.ca>

[-- Attachment #2: io_flash.cdl.diff --]
[-- Type: text/x-patch, Size: 821 bytes --]

--- a/packages/io/flash/current/cdl/io_flash.cdl
+++ b/packages/io/flash/current/cdl/io_flash.cdl
@@ -219,7 +219,7 @@
         default_value    1
         compile          legacy_api.c
         description      "
-            Provide an implementation of the lagacy user API. This is mapped 
+            Provide an implementation of the legacy user API. This is mapped
             onto the new API via a small layer of code"
     }
         
@@ -283,7 +283,7 @@
 			display         "Length"
 			flavor          data
 			default_value   0
-			requires        0 != CYGNUM_IO_FLASH_BLOCK_OFFSET_$::dev
+			requires        0 != CYGNUM_IO_FLASH_BLOCK_LENGTH_$::dev
 			description     "
                             This gives the length of the region of flash given over
                             to this block device."

[-- Attachment #3: ChangeLog.diff --]
[-- Type: text/x-patch, Size: 541 bytes --]

--- /a/ecos/packages/io/flash/current/ChangeLog
+++ /b/ecos/packages/io/flash/current/ChangeLog
@@ -1,3 +1,10 @@
+2010-03-25  Daniel Helgason  <dhelgason@shaw.ca>
+
+	* cdl/io_flash.cdl: Fix "requires" constraint on
+	CYGNUM_IO_FLASH_BLOCK_OFFSET_n to allow positioning of block device
+	at offset 0 in flash when using static configuration via offset.
+	Fix display string for CYGSEM_IO_FLASH_LEGACY_API option.
+
 2010-01-17  John Dallaway  <john@dallaway.org.uk>
 
 	* src/flashiodevlegacy.c: Specify flash block device lengths correctly

Re: Patch fixes bad "requires" constraint in io_flash.cdl

[Sergei Gavrikov]

On Thu, 25 Mar 2010, Daniel Helgason wrote:
> Attached is a patch to
>
> ecos/packages/io/flash/current/cdl/io_flash.cdl
>
> to fix bad "requires" constraint on CYGNUM_IO_FLASH_BLOCK_OFFSET_n in
> io_flash.cdl file.
>
> In the current version, it is not possible to position a block device at
> offset 0 in the flash using "Static configuration via offset" option.

Checked-in with CL entry.

Thanks.

Sergei