[Bug 1001187] New: New port: Freescale Kinetis variant, Freescale TWR-K60N512, Freescale UART device driver

[Bug 1001187] New: New port: Freescale Kinetis variant, Freescale TWR-K60N512, Freescale UART device driver

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

           Summary: New port: Freescale Kinetis variant, Freescale
                    TWR-K60N512, Freescale UART device driver
           Product: eCos
           Version: 3.0
          Platform: Other (please specify)
        OS/Version: Cortex-M
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: low
         Component: Patches and contributions
        AssignedTo: unassigned@bugs.ecos.sourceware.org
        ReportedBy: ilijak@siva.com.mk
                CC: ecos-patches@ecos.sourceware.org
             Class: Advice Request


Created an attachment (id=1198)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1198)
Kinetis HAL including variant and TWR-K60N512 platforrm

This is n eCos port to Freescale Kinetis Cortex-M4 micro-controller family.

Initial port consists of:
    - Kinetis variant : PLL clock, HAL diag serial communication.
    - TWR-K60N512 BSP platform : basic board specific settings and
initialization,
    - Freescale UART serial device driver: Interrupt driven serial driver.

Tested on Freescale TWR-K60N512 dev. kit. for both eCos (default template) and
RedBoot.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port: Freescale Kinetis variant, Freescale TWR-K60N512, Freescale UART device driver

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

--- Comment #1 from Ilija Kocho <ilijak@siva.com.mk> 2011-04-03 10:03:30 BST ---
Created an attachment (id=1199)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1199)
Freescale UART interrupt driven serial driver.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port: Freescale Kinetis variant, Freescale TWR-K60N512, Freescale UART device driver

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

--- Comment #2 from Ilija Kocho <ilijak@siva.com.mk> 2011-04-03 10:06:03 BST ---
Created an attachment (id=1200)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1200)
eCos database entries for HAL and UART packages / target.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port: Freescale Kinetis variant, Freescale TWR-K60N512, Freescale UART device driver

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |1001184, 1001186

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port: Freescale Kinetis variant, Freescale TWR-K60N512, Freescale UART device driver

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

Bug 1001187 depends on bug 1001184, which changed state.

Bug 1001184 Summary: Cortex-m arch: hal_intr.h includes var_intr.h too early.
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001184

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |CURRENTRELEASE

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port: Freescale Kinetis variant, Freescale TWR-K60N512, Freescale UART device driver

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

Bug 1001187 depends on bug 1001186, which changed state.

Bug 1001186 Summary: Introduce Cortex-M4 to the Cortex-M architecture
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001186

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |CURRENTRELEASE

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port: Freescale Kinetis variant, Freescale TWR-K60N512, Freescale UART device driver

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

--- Comment #3 from Ilija Kocho <ilijak@siva.com.mk> 2011-04-14 11:48:32 BST ---
Brief notes for patching Attachment 1198 and Attachment 1199 to local eCos
repository:

Assuming your current directory is "packages" invoke "patch" with option "-p2"
for Attachment 1198 (hal_kinetis.diff) and Attachment 1199
(ser_freescale_uart.diff). Otherwise "patch" may silently place them in wrong
directory.

Ilija

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port: Freescale Kinetis variant, Freescale TWR-K60N512, Freescale UART device driver

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1199|0                           |1
        is obsolete|                            |

--- Comment #4 from Ilija Kocho <ilijak@siva.com.mk> 2011-04-19 22:08:33 BST ---
Created an attachment (id=1211)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1211)
Freescale UART serial device driver 110419

CDL option for UART FIFO removed.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port: Freescale Kinetis variant, Freescale TWR-K60N512, Freescale UART device driver

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1198|0                           |1
        is obsolete|                            |

--- Comment #5 from Ilija Kocho <ilijak@siva.com.mk> 2011-04-19 22:24:39 BST ---
Created an attachment (id=1212)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1212)
Kinetis HAL variant / TWR-K60N512 patform 20110419

Here is updated Kinetis HAL,

Main difference is addition of SRAM startup that enables upload of eCos in
on-chip  SRAM by means of JTAG.

Topics for consideration:

1. FLASH sections:

1.1 Kinets controllers have a special area in FLASH at addr. 0x400..0x40F that
contains flash security configuration. 
In order to meet this, a new section is ".flash_security" introduced in MLT
files. Currently this section is encoded in natural form in MLT files (in a
same way as for Freescale MAC7100 port). I tried with USER_SECTION but ld
garbage collector discars this section as it is not referenced - so needs KEEP
parameter.

Comments/alternatives?


1.2 As a consequence of 1.1 flash area (1 KiB) below 0x400 is cut-off from main
flash body. In order to utilize this memory the USER_SECTION ".kinetis_misc" is
introduced. It currently accomodates functions from kinetis_misc.c (as well as
platform misc) but still remains about half empty. 

Please suggest candidate (functions, etc.) to fill this area.


2. SRAM Layout

Kinetis SRAM consists of two equal-size banks that occupy (consecutive) memory
blocks above and below 0x20000000. Below is example of K60N512 (2 x 64KiB)

      0x20010000    --------------
                    |    SRAM_U  |  <---> System Bus
      0x20000000 --------------------
                    |    SRAM_L  |  <---> Code bus
      0x1FFF0000    --------------

These blocks are being accessed by two separate Cortex-M buses (according to
Cortex-M architecture) allowing simultaneous access (by either Harward or
concurrent bus masters). On the other hand SRAM can also be used as flat area
allowing for better SRAM utilization.

In order to provide user a choice, the CDL option
CYGHWR_HAL_CORTEXM_KINETIS_SRAM_UNIFIED and parallel MLT files with unified and
non-unified SRAM are provided.

Comments?

Ilija

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port: Freescale Kinetis variant, Freescale TWR-K60N512, Freescale UART device driver

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.0                         |CVS

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port: Freescale Kinetis variant, Freescale TWR-K60N512, Freescale UART device driver

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

John Dallaway <john@dallaway.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEEDINFO
                 CC|                            |john@dallaway.org.uk
     Ever Confirmed|0                           |1

--- Comment #6 from John Dallaway <john@dallaway.org.uk> 2011-05-18 12:04:14 BST ---
Ilija

Thank you for the contribution.

(In reply to comment #5)

> Topics for consideration:
> 
> 1. FLASH sections:
> 
> 1.1 Kinets controllers have a special area in FLASH at addr. 0x400..0x40F that
> contains flash security configuration. 
> In order to meet this, a new section is ".flash_security" introduced in MLT
> files. Currently this section is encoded in natural form in MLT files (in a
> same way as for Freescale MAC7100 port). I tried with USER_SECTION but ld
> garbage collector discars this section as it is not referenced - so needs KEEP
> parameter.
> 
> Comments/alternatives?

As you point out, there is a precedent in the MAC7100 port. This is a quite
specialized requirement so probably OK to code without a macro but including
explanation in a comment. If we encounter other uses for a user-defined section
with KEEP attribute then we can (and should) add a new macro definition to
*.ld.

> 1.2 As a consequence of 1.1 flash area (1 KiB) below 0x400 is cut-off from 
> main flash body. In order to utilize this memory the USER_SECTION
> ".kinetis_misc" is introduced. It currently accomodates functions from
> kinetis_misc.c (as well as platform misc) but still remains about half empty.
> 
> Please suggest candidate (functions, etc.) to fill this area.

Since you have 128KiB SRAM on chip, filling the remaining 0.5KiB of the
.kinetis_misc section does not seem to be a high priority. I would leave this
available to allow the platform code to grow a little in the future.

> 2. SRAM Layout
> 
> Kinetis SRAM consists of two equal-size banks that occupy (consecutive) memory
> blocks above and below 0x20000000. Below is example of K60N512 (2 x 64KiB)
> 
>       0x20010000    --------------
>                     |    SRAM_U  |  <---> System Bus
>       0x20000000 --------------------
>                     |    SRAM_L  |  <---> Code bus
>       0x1FFF0000    --------------
> 
> These blocks are being accessed by two separate Cortex-M buses (according to
> Cortex-M architecture) allowing simultaneous access (by either Harward or
> concurrent bus masters). On the other hand SRAM can also be used as flat area
> allowing for better SRAM utilization.
> 
> In order to provide user a choice, the CDL option
> CYGHWR_HAL_CORTEXM_KINETIS_SRAM_UNIFIED and parallel MLT files with unified
> and non-unified SRAM are provided.

It looks like the "2x64" memory layouts just allocate into the upper 64KiB. How
do you envisage eCos developers using the lower 64KiB when not unified?

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port: Freescale Kinetis variant, Freescale TWR-K60N512, Freescale UART device driver

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

--- Comment #7 from Ilija Kocho <ilijak@siva.com.mk> 2011-05-19 11:29:38 BST ---
(In reply to comment #6)
> Ilija
> 
> Thank you for the contribution.

Thank you for your comments John.

> 
> (In reply to comment #5)
> 
> > Topics for consideration:
> > 
> > 1. FLASH sections:
> > 
> > 1.1 Kinets controllers have a special area in FLASH at addr. 0x400..0x40F that
> > contains flash security configuration. 
> > In order to meet this, a new section is ".flash_security" introduced in MLT
> > files. Currently this section is encoded in natural form in MLT files (in a
> > same way as for Freescale MAC7100 port). I tried with USER_SECTION but ld
> > garbage collector discars this section as it is not referenced - so needs KEEP
> > parameter.
> > 
> > Comments/alternatives?
> 
> As you point out, there is a precedent in the MAC7100 port. This is a quite
> specialized requirement so probably OK to code without a macro but including
> explanation in a comment. If we encounter other uses for a user-defined section
> with KEEP attribute then we can (and should) add a new macro definition to
> *.ld.
> 


There is a comment on Kinetis flash security accompanying code in
kinetis_misc.c. In ldi I can reference it.


> > 1.2 As a consequence of 1.1 flash area (1 KiB) below 0x400 is cut-off from 
> > main flash body. In order to utilize this memory the USER_SECTION
> > ".kinetis_misc" is introduced. It currently accomodates functions from
> > kinetis_misc.c (as well as platform misc) but still remains about half empty.
> > 
> > Please suggest candidate (functions, etc.) to fill this area.
> 
> Since you have 128KiB SRAM on chip, filling the remaining 0.5KiB of the
> .kinetis_misc section does not seem to be a high priority. I would leave this
> available to allow the platform code to grow a little in the future.
> 

Good approach. Platform HAL is growing indeed. 

> > 2. SRAM Layout
> > 
> > Kinetis SRAM consists of two equal-size banks that occupy (consecutive) memory
> > blocks above and below 0x20000000. Below is example of K60N512 (2 x 64KiB)
> > 
> >       0x20010000    --------------
> >                     |    SRAM_U  |  <---> System Bus
> >       0x20000000 --------------------
> >                     |    SRAM_L  |  <---> Code bus
> >       0x1FFF0000    --------------
> > 
> > These blocks are being accessed by two separate Cortex-M buses (according to
> > Cortex-M architecture) allowing simultaneous access (by either Harward or
> > concurrent bus masters). On the other hand SRAM can also be used as flat area
> > allowing for better SRAM utilization.
> > 
> > In order to provide user a choice, the CDL option
> > CYGHWR_HAL_CORTEXM_KINETIS_SRAM_UNIFIED and parallel MLT files with unified
> > and non-unified SRAM are provided.
> 
> It looks like the "2x64" memory layouts just allocate into the upper 64KiB. How
> do you envisage eCos developers using the lower 64KiB when not unified?

ROM 2x64
True, ROM 2x64 startup SRAM_L does not utilize by eCos directly. The idea is,
since SRAM_L is in Cortex-M code area, to use it as a fast extension of flash
where user could upload a code that needs fast execution (Present Kinetis run
up to 100Mhz, but maximum flash frequency is 25MHz. Some Kinetis members do
have cache, but some do not).

SRAM 2x64
SRAM startup 2x64 is trying to simulate ROM startup where SRAM_L emulates flash
and SRAM_U ram. In order to make behavior closer to ROM startup, even the
vectors are being copied. Naturally, this is not efficient usage of memory, but
is good way for user to simulate/learn ROM startup without burning flash (Maybe
I could put some word on this in description.)

To sum up, Kinetis memory configuration offers some flexibility and offered
memory configurations are attempt to reflect it in eCos and at the same time
point out eCos' configurability.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port: Freescale Kinetis variant, Freescale TWR-K60N512, Freescale UART device driver

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1212|0                           |1
        is obsolete|                            |

--- Comment #8 from Ilija Kocho <ilijak@siva.com.mk> 2011-06-04 10:56:45 BST ---
Created an attachment (id=1279)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1279)
Kinetis HAL variant / TWR-K60N512 patform 110602

Add comments on .flash_security section ( Comment #6 ).

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port: Freescale Kinetis variant, Freescale TWR-K60N512, Freescale UART device driver

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1211|0                           |1
        is obsolete|                            |

--- Comment #9 from Ilija Kocho <ilijak@siva.com.mk> 2011-06-04 10:58:05 BST ---
Created an attachment (id=1280)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1280)
Freescale UART serial device driver 110602

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port: Freescale Kinetis variant, Freescale TWR-K60N512, Freescale UART device driver

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

--- Comment #10 from Ilija Kocho <ilijak@siva.com.mk> 2011-06-04 11:01:39 BST ---
Created an attachment (id=1281)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1281)
Wallclock device driver for Kinetis RTC 110602

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port: Freescale Kinetis variant, Freescale TWR-K60N512, Freescale UART device driver

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1200|0                           |1
        is obsolete|                            |

--- Comment #11 from Ilija Kocho <ilijak@siva.com.mk> 2011-06-04 11:05:23 BST ---
Created an attachment (id=1282)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1282)
eCos database entries for HAL, UART and wallclock packages / target.

Add Wallclock driver for Kinetis RTC.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port: Freescale Kinetis variant, Freescale TWR-K60N512, Freescale UART device driver

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1279|0                           |1
        is obsolete|                            |

--- Comment #12 from Ilija Kocho <ilijak@siva.com.mk> 2011-08-28 15:14:47 BST ---
Created an attachment (id=1357)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1357)
Kinetis Variant HAL 110826

Here is updated Kinetis Variant.

Noteworthy:
CYG_HAL_STARTUP CDL component moved from Platform to Variant. With this
arrangement we have a single copy of CYG_HAL_STARTUP for all platforms that use
only on chip memory. For platforms with external memory, override possibility
is provided by means of CYG_HAL_STARTUP_PLF.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port: Freescale Kinetis variant, Freescale TWR-K60N512, Freescale UART device driver

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

--- Comment #13 from Ilija Kocho <ilijak@siva.com.mk> 2011-08-28 15:20:50 BST ---
Created an attachment (id=1358)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1358)
Kinetis TWR-K60N512 Platform HAL 110826

Now that we have more platforms I submit them in separate patches.
New: Ethernet related settings.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port: Freescale Kinetis variant, Freescale TWR-K60N512, Freescale UART device driver

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

--- Comment #14 from Ilija Kocho <ilijak@siva.com.mk> 2011-08-28 15:22:22 BST ---
Created an attachment (id=1359)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1359)
Kinetis TWR-K40X256 Platform HAL 110826

New platform.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port: Freescale Kinetis variant, Freescale TWR-K60N512, Freescale UART device driver

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1281|0                           |1
        is obsolete|                            |

--- Comment #15 from Ilija Kocho <ilijak@siva.com.mk> 2011-08-28 15:24:50 BST ---
Created an attachment (id=1360)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1360)
Wallclock device driver for Kinetis RTC 110826

Synced with 110826 HAL.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port: Freescale Kinetis variant, Freescale TWR-K60N512, Freescale UART device driver

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1280|0                           |1
        is obsolete|                            |

--- Comment #16 from Ilija Kocho <ilijak@siva.com.mk> 2011-08-28 15:26:10 BST ---
Created an attachment (id=1361)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1361)
Freescale UART serial device driver 110826

Synced with 110826 HAL

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port: Freescale Kinetis variant, Freescale TWR-K60N512, Freescale UART device driver

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

--- Comment #17 from Ilija Kocho <ilijak@siva.com.mk> 2011-08-28 15:32:15 BST ---
Created an attachment (id=1362)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1362)
Freescale ENET Ethernet driver 110826

Now we have Ethernet driver too.
Noteworthy:
Utilizes ENET's hardware (as well as lwIP provision) TCP/IP Checksum
generation/checking.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port: Freescale Kinetis variant, Freescale TWR-K60N512, Freescale UART device driver

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

--- Comment #18 from Ilija Kocho <ilijak@siva.com.mk> 2011-08-28 15:35:35 BST ---
Created an attachment (id=1363)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1363)
eCos database entries for Kinets HAL, Ethernet, UART and wallclock packages /
targets. 110826

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port: Freescale Kinetis variant, Freescale TWR-K60N512, Freescale UART device driver

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1282|0                           |1
        is obsolete|                            |

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port - HAL: Freescale Kinetis variant, TWR-K60N512, TWR-K40X256 plf; Devs: Freescale UART and ENET (Ethernet)

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|New port: Freescale Kinetis |New port - HAL: Freescale
                   |variant, Freescale          |Kinetis variant,
                   |TWR-K60N512, Freescale UART |TWR-K60N512, TWR-K40X256
                   |device driver               |plf; Devs: Freescale UART
                   |                            |and ENET (Ethernet)

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port - HAL: Freescale Kinetis variant, TWR-K60N512, TWR-K40X256 plf; Devs: Freescale UART and ENET (Ethernet)

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

--- Comment #19 from Ilija Kocho <ilijak@siva.com.mk> 2011-09-27 19:38:03 BST ---
Created an attachment (id=1380)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1380)
Freescale ENET Ethernet driver 110927

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port - HAL: Freescale Kinetis variant, TWR-K60N512, TWR-K40X256 plf; Devs: Freescale UART and ENET (Ethernet)

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1362|0                           |1
        is obsolete|                            |

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port - HAL: Freescale Kinetis variant, TWR-K60N512, TWR-K40X256 plf; Devs: Freescale UART and ENET (Ethernet)

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

--- Comment #21 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-10-17 21:31:57 BST ---
  Jifl> Nothing else leapt out at me. It seems a very good quality patch
  Jifl> from what I can tell.

Totally agree. That's very solid code. It looks great.

Nothing of importance can add. Only if view under a microscope :-)

Infusoria:

Ilija, if you will send some corrections, also, you would get rid the
trailing whitespaces (mostly in CDL) and expand a few tabs in ethernet
driver, also, I would get rid such shorthands

   }while(need_service);

there. And

wallclock:
+# Date:           2011.04.23

s/\./-/g

Sergei

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port - HAL: Freescale Kinetis variant, TWR-K60N512, TWR-K40X256 plf; Devs: Freescale UART and ENET (Ethernet)

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

--- Comment #22 from Ilija Kocho <ilijak@siva.com.mk> 2011-10-17 22:30:28 BST ---
(In reply to comment #20)
> As per direct mail, here's a few comments, although I haven't done what I'd
> call a full review:
> 
> 
> - I'll just mention that if extra TTYs are justified, then you should just
> modify CYGPKG_IO_SERIAL.


This has some history. The idea was a provision for adding (as much as needed)
additional tty/termios drivers into target without the need for changing IO.
Luckily after a long session with Sergei the patch was surprisingly short.
Please see: http://ecos.sourceware.org/ml/ecos-devel/2011-03/msg00023.html
Also:      Bug #1001180


> 
> - "familly" should be spelt "family", and "acces" -> "access"

Thank you. Luckily there isn't wellcome (pardon welcome) or luckilly :) in my
text.

> 
> - CDL display names shouldn't really end in full-stops ("."). The best way to
> decide what to use for display names is to think of what would be best in the
> graphical configuration tool - even if you, like many maintainers, don't use
> it, lots of eCos users do.

I'm trying to make the displays as appropriate as I can, but sometimes they
resemble sentences - hence full-stops. I'll clean them.

> 
> - Various components which are "flavor none" should also have "no_define".

I don't know why, but I had impression that flavor none are no_define by
default... but now I know they aren't.

> 
> - The CYGPKG_HAL_CORTEXM_KINETIS .cdl file is quite big - perhaps the
> components related to clocking could be split off into a separate file, and
> included. 


Yeah. This clock is more complex than some 8-bit micro-controllers. Good idea.
This brings me an idea of extracting clocking code from kinetis_misc.c?

kinetis_clocking.cdl
kinetis_clocking.c

Any comment?


> 
> - This bit in hal_diag.c:
> +#if defined(CYGOPT_HAL_KINETIS_DIAG_IN_MISC_FLASH_SECTION) && \
> +        CYGOPT_HAL_KINETIS_DIAG_IN_MISC_FLASH_SECTION
> +#  define CYGOPT_HAL_KINETIS_DIAG_FLASH_SECTION_ATTR         \
> +        CYGOPT_HAL_KINETIS_MISC_FLASH_SECTION_ATTR
> +#else
> +#  define CYGOPT_HAL_KINETIS_DIAG_FLASH_SECTION_ATTR
> +#endif
> 
> I think you originally meant to begin that with:
> +#if defined(CYGOPT_HAL_KINETIS_DIAG_IN_MISC_FLASH_SECTION) && \
> +        CYGOPT_HAL_KINETIS_MISC_FLASH_SECTION_ATTR
> 


It probably used to be flavor data or booldata defining section name. Than I
decided to simplify it (literal section name), but preprocessor code remained.
I'll look for eventual other cases.


> But given the CDL you can probably just use:
> #ifdef CYGOPT_HAL_KINETIS_DIAG_IN_MISC_FLASH_SECTION
> 
> 
> Nothing else leapt out at me. It seems a very good quality patch from what I
> can tell.
> 

Thank you for good advices.
Ilija

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port - HAL: Freescale Kinetis variant, TWR-K60N512, TWR-K40X256 plf; Devs: Freescale UART and ENET (Ethernet)

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

--- Comment #23 from Ilija Kocho <ilijak@siva.com.mk> 2011-10-17 23:25:15 BST ---
Hi Sergei

Thank you for jumping in.

(In reply to comment #21)
>   Jifl> Nothing else leapt out at me. It seems a very good quality patch
>   Jifl> from what I can tell.
> 
> Totally agree. That's very solid code. It looks great.
> 
> Nothing of importance can add. Only if view under a microscope :-)

Perfection is when there's nothing to take out.
                          (Antoine de Saint-Exupéry)
> 
> Infusoria:
> 
> Ilija, if you will send some corrections, also, you would get rid the
> trailing whitespaces (mostly in CDL) and expand a few tabs in ethernet

Recently I have installed a macro in my editor [me] that removes trailing
whitespace prior to saving. I hope new files shall come cleaner.

> driver, also, I would get rid such shorthands
> 
>    }while(need_service);

I will try to find more appropriate term. Maybe: "need_delivery"
"pending_delivery"...

> 
> there. And
> 
> wallclock:
> +# Date:           2011.04.23

Changed.

CU
Ilija

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port - HAL: Freescale Kinetis variant, TWR-K60N512, TWR-K40X256 plf; Devs: Freescale UART and ENET (Ethernet)

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

--- Comment #24 from Jonathan Larmour <jifl@ecoscentric.com> 2011-10-18 00:28:22 BST ---
(In reply to comment #22)
> (In reply to comment #20)
> > As per direct mail, here's a few comments, although I haven't done what I'd
> > call a full review:
> > 
> > 
> > - I'll just mention that if extra TTYs are justified, then you should just
> > modify CYGPKG_IO_SERIAL.
> 
> 
> This has some history. The idea was a provision for adding (as much as needed)
> additional tty/termios drivers into target without the need for changing IO.
> Luckily after a long session with Sergei the patch was surprisingly short.
> Please see: http://ecos.sourceware.org/ml/ecos-devel/2011-03/msg00023.html
> Also:      Bug #1001180

Personally I would take a pragmatic approach and just increase the number of
devices to 6. However using a 'for' loop in the CDL, would be a good
rationalisation.

> > - The CYGPKG_HAL_CORTEXM_KINETIS .cdl file is quite big - perhaps the
> > components related to clocking could be split off into a separate file, and
> > included. 
> 
> 
> Yeah. This clock is more complex than some 8-bit micro-controllers. Good idea.
> This brings me an idea of extracting clocking code from kinetis_misc.c?
> 
> kinetis_clocking.cdl
> kinetis_clocking.c
> 
> Any comment?

That would probably be good too. It makes it more maintainable to have all the
clock things in one place, and for files not to get too large.

Thanks for all the other responses.

Jifl

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port - HAL: Freescale Kinetis variant, TWR-K60N512, TWR-K40X256 plf; Devs: Freescale UART and ENET (Ethernet)

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

--- Comment #25 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-10-18 07:03:28 BST ---
(In reply to comment #23)
> > driver, also, I would get rid such shorthands
> > 
> >    }while(need_service);
> 
> I will try to find more appropriate term. Maybe: "need_delivery"
> "pending_delivery"...

I used bad term, shorthands. I meaned eCos coding style only

    } while(need_service);


Sergei

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port - HAL: Freescale Kinetis variant, TWR-K60N512, TWR-K40X256 plf; Devs: Freescale UART and ENET (Ethernet)

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1357|0                           |1
        is obsolete|                            |

--- Comment #26 from Ilija Kocho <ilijak@siva.com.mk> 2011-10-23 23:29:48 BST ---
Created an attachment (id=1406)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1406)
Kinetis Variant HAL 111023

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port - HAL: Freescale Kinetis variant, TWR-K60N512, TWR-K40X256 plf; Devs: Freescale UART and ENET (Ethernet)

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1358|0                           |1
        is obsolete|                            |

--- Comment #27 from Ilija Kocho <ilijak@siva.com.mk> 2011-10-23 23:30:56 BST ---
Created an attachment (id=1407)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1407)
Kinetis TWR-K60N512 Platform HAL 111023

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port - HAL: Freescale Kinetis variant, TWR-K60N512, TWR-K40X256 plf; Devs: Freescale UART and ENET (Ethernet)

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1359|0                           |1
        is obsolete|                            |

--- Comment #28 from Ilija Kocho <ilijak@siva.com.mk> 2011-10-23 23:31:51 BST ---
Created an attachment (id=1408)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1408)
Kinetis TWR-K40X256 Platform HAL 111023

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port - HAL: Freescale Kinetis variant, TWR-K60N512, TWR-K40X256 plf; Devs: Freescale UART and ENET (Ethernet)

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1380|0                           |1
        is obsolete|                            |

--- Comment #29 from Ilija Kocho <ilijak@siva.com.mk> 2011-10-23 23:33:29 BST ---
Created an attachment (id=1409)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1409)
Freescale ENET Ethernet driver 111023

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port - HAL: Freescale Kinetis variant, TWR-K60N512, TWR-K40X256 plf; Devs: Freescale UART and ENET (Ethernet)

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1361|0                           |1
        is obsolete|                            |

--- Comment #30 from Ilija Kocho <ilijak@siva.com.mk> 2011-10-23 23:34:30 BST ---
Created an attachment (id=1410)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1410)
Freescale UART serial device driver 110826

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port - HAL: Freescale Kinetis variant, TWR-K60N512, TWR-K40X256 plf; Devs: Freescale UART and ENET (Ethernet)

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1360|0                           |1
        is obsolete|                            |

--- Comment #31 from Ilija Kocho <ilijak@siva.com.mk> 2011-10-23 23:35:35 BST ---
Created an attachment (id=1411)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1411)
Wallclock device driver for Kinetis RTC 111023

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port - HAL: Freescale Kinetis variant, TWR-K60N512, TWR-K40X256 plf; Devs: Freescale UART and ENET (Ethernet)

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

--- Comment #32 from Ilija Kocho <ilijak@siva.com.mk> 2011-10-23 23:38:23 BST ---
Created an attachment (id=1412)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1412)
eCos database entries for Kinets HAL, Ethernet, UART and wallclock packages /
targets. 111023

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port - HAL: Freescale Kinetis variant, TWR-K60N512, TWR-K40X256 plf; Devs: Freescale UART and ENET (Ethernet)

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1363|0                           |1
        is obsolete|                            |

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port - HAL: Freescale Kinetis variant, TWR-K60N512, TWR-K40X256 plf; Devs: Freescale UART and ENET (Ethernet)

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1406|0                           |1
        is obsolete|                            |

--- Comment #33 from Ilija Kocho <ilijak@siva.com.mk> 2011-10-25 12:05:00 BST ---
Created an attachment (id=1414)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1414)
Kinetis Variant HAL 111025

Some macros from var_io.h moved to separate files var_io_devs.h
var_io_flexbus.h
Some FlexBus related macros removed from var_io.h.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port - HAL: Freescale Kinetis variant, TWR-K60N512, TWR-K40X256 plf; Devs: Freescale UART and ENET (Ethernet)

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1414|0                           |1
        is obsolete|                            |

--- Comment #34 from Ilija Kocho <ilijak@siva.com.mk> 2011-10-27 08:20:08 BST ---
Created an attachment (id=1415)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1415)
Kinetis Variant HAL 111026

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port - HAL: Freescale Kinetis variant, TWR-K60N512, TWR-K40X256 plf; Devs: Freescale UART and ENET (Ethernet)

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

--- Comment #35 from Ilija Kocho <ilijak@siva.com.mk> 2011-10-27 08:21:28 BST ---
Created an attachment (id=1416)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1416)
Kinetis TWR-K60N512 Platform HAL 111026

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port - HAL: Freescale Kinetis variant, TWR-K60N512, TWR-K40X256 plf; Devs: Freescale UART and ENET (Ethernet)

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1407|0                           |1
        is obsolete|                            |

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port - HAL: Freescale Kinetis variant, TWR-K60N512, TWR-K40X256 plf; Devs: Freescale UART and ENET (Ethernet)

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1408|0                           |1
        is obsolete|                            |

--- Comment #36 from Ilija Kocho <ilijak@siva.com.mk> 2011-10-27 08:23:04 BST ---
Created an attachment (id=1417)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1417)
Kinetis TWR-K40X256 Platform HAL 111026

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port - HAL: Freescale Kinetis variant, TWR-K60N512, TWR-K40X256 plf; Devs: Freescale UART and ENET (Ethernet)

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1410|0                           |1
        is obsolete|                            |

--- Comment #37 from Ilija Kocho <ilijak@siva.com.mk> 2011-10-27 08:24:40 BST ---
Created an attachment (id=1418)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1418)
Freescale UART serial device driver 111026

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port - HAL: Freescale Kinetis variant, TWR-K60N512, TWR-K40X256 plf; Devs: Freescale UART and ENET (Ethernet)

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1409|0                           |1
        is obsolete|                            |

--- Comment #38 from Ilija Kocho <ilijak@siva.com.mk> 2011-10-27 08:26:10 BST ---
Created an attachment (id=1419)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1419)
Freescale ENET Ethernet driver 111026

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port - HAL: Freescale Kinetis variant, TWR-K60N512, TWR-K40X256 plf; Devs: Freescale UART and ENET (Ethernet)

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

--- Comment #39 from Ilija Kocho <ilijak@siva.com.mk> 2011-10-27 18:22:19 BST ---
(In reply to comment #21)

Hi Sergei

I have updated the Kinetis, patches and the code is now ready for review.

> Infusoria:
> 
> Ilija, if you will send some corrections, also, you would get rid the
> trailing whitespaces (mostly in CDL) and expand a few tabs in ethernet
> driver, also, I would get rid such shorthands
> 
>    }while(need_service);

I hope all trailing whitespace is taken out and formating set. Regarding famous
78 char length, you will still find some lines that exceed it as exceptions
where I find it (more) convenient and natural.

Ilija

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port - HAL: Freescale Kinetis variant, TWR-K60N512, TWR-K40X256 plf; Devs: Freescale UART and ENET (Ethernet)

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

--- Comment #40 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-10-27 21:37:36 BST ---
(In reply to comment #39)
> Hi Sergei

Hi Ilija,

> I have updated the Kinetis, patches and the code is now ready for
> review.
> 
> > Infusoria:
> > 
> > Ilija, if you will send some corrections, also, you would get rid
> > the trailing whitespaces (mostly in CDL) and expand a few tabs in
> > ethernet driver, also, I would get rid such shorthands
> > 
> >    }while(need_service);
> 
> I hope all trailing whitespace is taken out and formating set.

Even more than :-) A global search-n-replace (or script) did rid and
white spaces in the eCos copyright headers. A few lines in my ~/.vimrc
regarding 'BadWhitespace' made me too picky :-) But as much as they are
highlighted in *red* I'm picking on them. Perhaps today this arraignment
seem archaic and I'm thinking what I should comment them out (I mean my
settings for $EDITOR).

No need to re-send the patches, I'll raise those banners.

> Regarding famous 78 char length, you will still find some lines that
> exceed it as exceptions where I find it (more) convenient and natural.

Right. It is not always possible, especially for macros.  I will look
over the final version and try to build.  Unfortunately, I could do it
tomorrow or the next day.  Thank you for your time and your attention
to details.

Sergei

> Ilija

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port - HAL: Freescale Kinetis variant, TWR-K60N512, TWR-K40X256 plf; Devs: Freescale UART and ENET (Ethernet)

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

--- Comment #41 from Ilija Kocho <ilijak@siva.com.mk> 2011-10-27 23:03:56 BST ---
(In reply to comment #40)
> (In reply to comment #39)
> > Hi Sergei
> 
> Hi Ilija,
> 
> > > Ilija, if you will send some corrections, also, you would get rid
> > > the trailing whitespaces (mostly in CDL) and expand a few tabs in
> > > ethernet driver, also, I would get rid such shorthands
> > > 
> > >    }while(need_service);
> > 
> > I hope all trailing whitespace is taken out and formating set.
> 
> Even more than :-) A global search-n-replace (or script) did rid and
> white spaces in the eCos copyright headers. A few lines in my ~/.vimrc
> regarding 'BadWhitespace' made me too picky :-) But as much as they are
> highlighted in *red* I'm picking on them. Perhaps today this arraignment
> seem archaic and I'm thinking what I should comment them out (I mean my
> settings for $EDITOR).
> 

So copyright banner has different rules...
I could adapt the clean macro in my editor for future.
What are the rules for whitespace?

> No need to re-send the patches, I'll raise those banners.

Tank you.

Ilija

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port - HAL: Freescale Kinetis variant, TWR-K60N512, TWR-K40X256 plf; Devs: Freescale UART and ENET (Ethernet)

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

--- Comment #42 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-10-29 11:11:19 BST ---
So, my test MQ for bug 1001187 includes

    Attachment 1411 (wallclock)
    Attachment 1412 (ecos.db)
    Attachment 1415 (variant)
    Attachment 1416 (k60n512)
    Attachment 1417 (k40x256)
    Attachment 1418 (serial)
    Attachment 1419 (ethernet)

Ilija, check the list, please. I've tested the next builds for new targets

k40x256: template default 
         + CYGPKG_IO_SERIAL_DEVICES

k60n512: template default
         + CYGPKG_NET_LWIP
     + CYGPKG_IO_ETH_DRIVERS
     + CYGPKG_IO_SERIAL_DEVICES

All passed smoothly (were built all libraries and tests, builds are clean).

Hope that I missed nothing. If it is all right I will happy to commit the
stuff the other day.

Sergei

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port - HAL: Freescale Kinetis variant, TWR-K60N512, TWR-K40X256 plf; Devs: Freescale UART and ENET (Ethernet)

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

--- Comment #43 from Ilija Kocho <ilijak@siva.com.mk> 2011-10-29 19:30:32 BST ---
(In reply to comment #42)
> So, my test MQ for bug 1001187 includes
> 
>     Attachment 1411 [details] (wallclock)
>     Attachment 1412 [details] (ecos.db)
>     Attachment 1415 [details] (variant)
>     Attachment 1416 [details] (k60n512)
>     Attachment 1417 [details] (k40x256)
>     Attachment 1418 [details] (serial)
>     Attachment 1419 [details] (ethernet)
> 

That's it.

> Ilija, check the list, please. I've tested the next builds for new targets
> 
> k40x256: template default 
>          + CYGPKG_IO_SERIAL_DEVICES
> 
> k60n512: template default
>          + CYGPKG_NET_LWIP
>      + CYGPKG_IO_ETH_DRIVERS
>      + CYGPKG_IO_SERIAL_DEVICES
> 
> All passed smoothly (were built all libraries and tests, builds are clean).
> 
> Hope that I missed nothing. If it is all right I will happy to commit the
> stuff the other day.

Everything seems OK. Thank you.

Please carry on.

Ilija

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port - HAL: Freescale Kinetis variant, TWR-K60N512, TWR-K40X256 plf; Devs: Freescale UART and ENET (Ethernet)

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

--- Comment #44 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-10-30 20:47:59 GMT ---
Now in CVS.

Ilija, many thanks for your contribution. Jonathan, John thank you both
for your review and expertise.

Sergei

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port - HAL: Freescale Kinetis variant, TWR-K60N512, TWR-K40X256 plf; Devs: Freescale UART and ENET (Ethernet)

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

--- Comment #45 from John Dallaway <john@dallaway.org.uk> 2011-10-30 22:35:19 GMT ---
(In reply to comment #44)

> Now in CVS.

This is great news for eCos! Many thanks to everyone involved. I have updated
the hardware table at: http://ecos.sourceware.org/hardware.html

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port - HAL: Freescale Kinetis variant, TWR-K60N512, TWR-K40X256 plf; Devs: Freescale UART and ENET (Ethernet)

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

--- Comment #46 from Ilija Kocho <ilijak@siva.com.mk> 2011-10-31 10:34:12 GMT ---
(In reply to comment #44)
> Now in CVS.
> 
> Ilija, many thanks for your contribution. Jonathan, John thank you both
> for your review and expertise.
> 
> Sergei

Sergei, thank you for testing and commit. Also thanks to John and Jifl for
comments.

I have checked out from CVS and tried on both platforms. Everything OK.

(In reply to comment #45)
> 
> This is great news for eCos! Many thanks to everyone involved. I have updated
> the hardware table at: http://ecos.sourceware.org/hardware.html

John, thank you for spreading the word.
Just a little detail [my fault :( ] I have failed to mention it but Kinetis
port also supports RedBoot :) on both platforms (K60 also via network).

Ilija

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001187] New port - HAL: Freescale Kinetis variant, TWR-K60N512, TWR-K40X256 plf; Devs: Freescale UART and ENET (Ethernet)

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001187

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |RESOLVED
         Resolution|                            |CURRENTRELEASE

--- Comment #47 from Ilija Kocho <ilijak@siva.com.mk> 2011-11-01 11:17:11 GMT ---
Committed to CVS,

Checkout from CVS (re)tested: Build - clean. Basic tests pass.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.