From: bugzilla-daemon@bugs.ecos.sourceware.org
To: ecos-patches@ecos.sourceware.org
Subject: [Bug 1001571] New: Make CYGHWR_HAL_STM32_PIN_IN consistent on STM32
Date: Mon, 23 Apr 2012 15:09:00 -0000 [thread overview]
Message-ID: <bug-1001571-104@http.bugs.ecos.sourceware.org/> (raw)
Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001571
Summary: Make CYGHWR_HAL_STM32_PIN_IN consistent on STM32
Product: eCos
Version: CVS
Platform: stm32e_eval (ST STM3210E EVAL board)
OS/Version: Cortex-M
Status: NEW
Severity: minor
Priority: low
Component: Patches and contributions
AssignedTo: jifl@ecoscentric.com
ReportedBy: jifl@ecoscentric.com
CC: ecos-patches@ecos.sourceware.org, jerzdy@gmail.com
Class: Advice Request
We just discovered a little issue with the definition of
CYGHWR_HAL_STM32_PIN_IN. It's internally consistent (so people may not have
noticed any problem for a long time), but the F1 and F2 versions of this macro
were not consistent with each other, which defeats the goal of keeping them
consistent. This patch addresses that.
I'm committing it.
Jerzy, you may want to take note in case it affects you. In our own plf_io.h
for an STM3210c board with ethernet, we made this change:
-#define CYGHWR_HAL_STM32_ETH_MII_RX_DV CYGHWR_HAL_STM32_PIN_IN( D,
8, NA , FLOATING )
-#define CYGHWR_HAL_STM32_ETH_MII_RXD0 CYGHWR_HAL_STM32_PIN_IN( D,
9, NA , FLOATING )
-#define CYGHWR_HAL_STM32_ETH_MII_RXD1 CYGHWR_HAL_STM32_PIN_IN( D,
10, NA , FLOATING )
-#define CYGHWR_HAL_STM32_ETH_MII_RXD2 CYGHWR_HAL_STM32_PIN_IN( D,
11, NA , FLOATING )
-#define CYGHWR_HAL_STM32_ETH_MII_RXD3 CYGHWR_HAL_STM32_PIN_IN( D,
12, NA , FLOATING )
+#define CYGHWR_HAL_STM32_ETH_MII_RX_DV CYGHWR_HAL_STM32_PIN_IN( D,
8, FLOATING )
+#define CYGHWR_HAL_STM32_ETH_MII_RXD0 CYGHWR_HAL_STM32_PIN_IN( D,
9, FLOATING )
+#define CYGHWR_HAL_STM32_ETH_MII_RXD1 CYGHWR_HAL_STM32_PIN_IN( D,
10, FLOATING )
+#define CYGHWR_HAL_STM32_ETH_MII_RXD2 CYGHWR_HAL_STM32_PIN_IN( D,
11, FLOATING )
+#define CYGHWR_HAL_STM32_ETH_MII_RXD3 CYGHWR_HAL_STM32_PIN_IN( D,
12, FLOATING )
Again, if you prefer to replace the defines in var_io_eth.h with your own, do;
don't feel compelled to use ours if you don't want to.
Jifl
--
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
next reply other threads:[~2012-04-23 15:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-23 15:09 bugzilla-daemon [this message]
2012-04-23 15:23 ` [Bug 1001571] " bugzilla-daemon
2012-04-23 15:23 ` bugzilla-daemon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-1001571-104@http.bugs.ecos.sourceware.org/ \
--to=bugzilla-daemon@bugs.ecos.sourceware.org \
--cc=ecos-patches@ecos.sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).