[Bug 1001571] New: Make CYGHWR_HAL_STM32_PIN_IN consistent on STM32

[Bug 1001571] New: Make CYGHWR_HAL_STM32_PIN_IN consistent on STM32

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001571

           Summary: Make CYGHWR_HAL_STM32_PIN_IN consistent on STM32
           Product: eCos
           Version: CVS
          Platform: stm32e_eval (ST STM3210E EVAL board)
        OS/Version: Cortex-M
            Status: NEW
          Severity: minor
          Priority: low
         Component: Patches and contributions
        AssignedTo: jifl@ecoscentric.com
        ReportedBy: jifl@ecoscentric.com
                CC: ecos-patches@ecos.sourceware.org, jerzdy@gmail.com
             Class: Advice Request


We just discovered a little issue with the definition of
CYGHWR_HAL_STM32_PIN_IN. It's internally consistent (so people may not have
noticed any problem for a long time), but the F1 and F2 versions of this macro
were not consistent with each other, which defeats the goal of keeping them
consistent. This patch addresses that.

I'm committing it.

Jerzy, you may want to take note in case it affects you. In our own plf_io.h
for an STM3210c board with ethernet, we made this change: 

-#define CYGHWR_HAL_STM32_ETH_MII_RX_DV          CYGHWR_HAL_STM32_PIN_IN( D, 
8, NA , FLOATING )
-#define CYGHWR_HAL_STM32_ETH_MII_RXD0           CYGHWR_HAL_STM32_PIN_IN( D, 
9, NA , FLOATING )
-#define CYGHWR_HAL_STM32_ETH_MII_RXD1           CYGHWR_HAL_STM32_PIN_IN( D,
10, NA , FLOATING )
-#define CYGHWR_HAL_STM32_ETH_MII_RXD2           CYGHWR_HAL_STM32_PIN_IN( D,
11, NA , FLOATING )
-#define CYGHWR_HAL_STM32_ETH_MII_RXD3           CYGHWR_HAL_STM32_PIN_IN( D,
12, NA , FLOATING )
+#define CYGHWR_HAL_STM32_ETH_MII_RX_DV          CYGHWR_HAL_STM32_PIN_IN( D, 
8, FLOATING )
+#define CYGHWR_HAL_STM32_ETH_MII_RXD0           CYGHWR_HAL_STM32_PIN_IN( D, 
9, FLOATING )
+#define CYGHWR_HAL_STM32_ETH_MII_RXD1           CYGHWR_HAL_STM32_PIN_IN( D,
10, FLOATING )
+#define CYGHWR_HAL_STM32_ETH_MII_RXD2           CYGHWR_HAL_STM32_PIN_IN( D,
11, FLOATING )
+#define CYGHWR_HAL_STM32_ETH_MII_RXD3           CYGHWR_HAL_STM32_PIN_IN( D,
12, FLOATING )

Again, if you prefer to replace the defines in var_io_eth.h with your own, do;
don't feel compelled to use ours if you don't want to.

Jifl

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001571] Make CYGHWR_HAL_STM32_PIN_IN consistent on STM32

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001571

Jonathan Larmour <jifl@ecoscentric.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1711|                            |assignment+, review+
               Flag|                            |

--- Comment #1 from Jonathan Larmour <jifl@ecoscentric.com> 2012-04-23 16:22:45 BST ---
Created an attachment (id=1711)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1711)
STM32 variant CYGHWR_HAL_STM32_PIN_IN consistency fix

Bugzilla failed to attached the patch, hrm. Trying again...

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001571] Make CYGHWR_HAL_STM32_PIN_IN consistent on STM32

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001571

Jonathan Larmour <jifl@ecoscentric.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |NEXTRELEASE

--- Comment #2 from Jonathan Larmour <jifl@ecoscentric.com> 2012-04-23 16:23:05 BST ---
Applied.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.