* [PATCH] lib: remove unused `STROF` definition (NFC)
@ 2021-08-27 15:20 Saleem Abdulrasool
2021-08-27 16:31 ` Mark Wielaard
0 siblings, 1 reply; 2+ messages in thread
From: Saleem Abdulrasool @ 2021-08-27 15:20 UTC (permalink / raw)
To: elfutils-devel
This definition was in the fallback path, where `sys/cdefs.h` is not
available. Now that we have a single path through here, this macro gets
defined, though is unused. Remove the unused macro definition.
Signed-off-by: Saleem Abdulrasool <abdulras@google.com>
---
lib/ChangeLog | 4 ++++
lib/fixedsizehash.h | 1 -
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/lib/ChangeLog b/lib/ChangeLog
index a95f8041..5f1de1e2 100644
--- a/lib/ChangeLog
+++ b/lib/ChangeLog
@@ -1,3 +1,7 @@
+2021-08-21 Saleem Abdulrasool <abdulras@google.com>
+
+ * fixedsizehash.h: Remove unused STROF macro.
+
2021-08-20 Saleem Abdulrasool <abdulras@google.com>
* fixedsizehash.h: Remove sys/cdefs.h include. Unconditionally
diff --git a/lib/fixedsizehash.h b/lib/fixedsizehash.h
index f333ad99..14f0fb88 100644
--- a/lib/fixedsizehash.h
+++ b/lib/fixedsizehash.h
@@ -33,7 +33,6 @@
#include <system.h>
-#define STROF(t2) t2
#define CONCAT_EXPANDED(t1,t2) t1 ## t2
#define CONCAT(t1,t2) CONCAT_EXPANDED(t1,t2)
--
2.33.0.259.gc128427fd7-goog
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] lib: remove unused `STROF` definition (NFC)
2021-08-27 15:20 [PATCH] lib: remove unused `STROF` definition (NFC) Saleem Abdulrasool
@ 2021-08-27 16:31 ` Mark Wielaard
0 siblings, 0 replies; 2+ messages in thread
From: Mark Wielaard @ 2021-08-27 16:31 UTC (permalink / raw)
To: Saleem Abdulrasool, elfutils-devel
Hi Saleem,
On Fri, 2021-08-27 at 15:20 +0000, Saleem Abdulrasool via Elfutils-devel wrote:
> This definition was in the fallback path, where `sys/cdefs.h` is not
> available. Now that we have a single path through here, this macro gets
> defined, though is unused. Remove the unused macro definition.
The STROF macro is not used, so this is indeed a NFC.
Pushed.
Thanks,
Mark
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-27 16:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-27 15:20 [PATCH] lib: remove unused `STROF` definition (NFC) Saleem Abdulrasool
2021-08-27 16:31 ` Mark Wielaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).