Re: [PATCH] configure: Error when demangler is enabled, but libstdc++ support isn't

[Mark Wielaard <mark@klomp.org>]

Hi Florian,

On Thu, 2023-02-16 at 11:48 +0100, Florian Weimer via Elfutils-devel
wrote:
> * Mark Wielaard:
> 
> > +      [AC_MSG_ERROR([__cxa_demangle not found in libstdc++ use --disable-demangler to disable demangler support.])]),
> 
> Missing punctuation after libstdc++?

You probably mean you like to see a comma after libstdc++?
That sounds reasonable. But I had to double quote the argument to
AC_MSG_ERROR, otherwise the comma was seen as a argument separator?
Which I find slightly odd, but I don't fully grok autoconf quotes.

Does the following do what you expect?

diff --git a/configure.ac b/configure.ac
index 1ef45c0f..4c8a4c31 100644
--- a/configure.ac
+++ b/configure.ac
@@ -499,7 +499,7 @@ AC_DEFINE([USE_DEMANGLE], [1], [Defined if demangling is enabled])])
 AM_CONDITIONAL(DEMANGLE, test "x$ac_cv_lib_stdcpp___cxa_demangle" = "xyes")
 AS_IF([test "x$ac_cv_lib_stdcpp___cxa_demangle" = "xyes"],
       [enable_demangler=yes],
-      [AC_MSG_ERROR([__cxa_demangle not found in libstdc++ use --disable-demangler to disable demangler support.])]),
+      [AC_MSG_ERROR([[__cxa_demangle not found in libstdc++, use --disable-demangler to disable demangler support.]])]),
 AM_CONDITIONAL(DEMANGLE, false))
 
 AC_ARG_ENABLE([textrelcheck],

Thanks,

Mark