From: Florian Weimer <fweimer@redhat.com>
To: Mark Wielaard <mark@klomp.org>
Cc: elfutils-devel@sourceware.org
Subject: Re: [PATCH] configure: Error when demangler is enabled, but libstdc++ support isn't
Date: Thu, 16 Feb 2023 18:02:49 +0100 [thread overview]
Message-ID: <87wn4hpmpy.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <188c194df1b722440dd6f8757390b26a42a94cfa.camel@klomp.org> (Mark Wielaard's message of "Thu, 16 Feb 2023 14:08:03 +0100")
* Mark Wielaard:
> Hi Florian,
>
> On Thu, 2023-02-16 at 11:48 +0100, Florian Weimer via Elfutils-devel
> wrote:
>> * Mark Wielaard:
>>
>> > + [AC_MSG_ERROR([__cxa_demangle not found in libstdc++ use --disable-demangler to disable demangler support.])]),
>>
>> Missing punctuation after libstdc++?
>
> You probably mean you like to see a comma after libstdc++?
Comma or semicolon.
> That sounds reasonable. But I had to double quote the argument to
> AC_MSG_ERROR, otherwise the comma was seen as a argument separator?
Ohh. I had not consider that.
> Which I find slightly odd, but I don't fully grok autoconf quotes.
>
> Does the following do what you expect?
Yes, but even though I patched dozens of m4 files lately, I still don't
get the quoting rules. For me, it's mostly “add […] until it breaks,
then remove one layer” …
Thanks,
Florian
next prev parent reply other threads:[~2023-02-16 17:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 16:00 Mark Wielaard
2023-02-16 10:48 ` Florian Weimer
2023-02-16 13:08 ` Mark Wielaard
2023-02-16 17:02 ` Florian Weimer [this message]
2023-02-16 23:09 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wn4hpmpy.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=elfutils-devel@sourceware.org \
--cc=mark@klomp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).