[PATCH] Drop *_so_SOURCES from libasm, libdw, libelf Makefile.am

[PATCH] Drop *_so_SOURCES from libasm, libdw, libelf Makefile.am

[Ulf Hermann]

They aren't used and cause warnings from autoconf.

Signed-off-by: Ulf Hermann <ulf.hermann@qt.io>
---
 libasm/ChangeLog   | 4 ++++
 libasm/Makefile.am | 1 -
 libdw/ChangeLog    | 4 ++++
 libdw/Makefile.am  | 1 -
 libelf/ChangeLog   | 4 ++++
 libelf/Makefile.am | 1 -
 6 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/libasm/ChangeLog b/libasm/ChangeLog
index fffcced0..fb282e3e 100644
--- a/libasm/ChangeLog
+++ b/libasm/ChangeLog
@@ -1,3 +1,7 @@
+2017-08-18  Ulf Hermann  <ulf.hermann@qt.io>
+
+	* Makefile.am: Drop libasm_so_SOURCES.
+
 2017-02-27  Ulf Hermann  <ulf.hermann@qt.io>
 
 	* Makefile.am: Use dso_LDFLAGS.
diff --git a/libasm/Makefile.am b/libasm/Makefile.am
index 19fef508..29d2efee 100644
--- a/libasm/Makefile.am
+++ b/libasm/Makefile.am
@@ -62,7 +62,6 @@ libasm_so_LDLIBS += -lpthread
 endif
 
 libasm_so_LIBS = libasm_pic.a
-libasm_so_SOURCES =
 libasm.so$(EXEEXT): $(srcdir)/libasm.map $(libasm_so_LIBS) $(libasm_so_DEPS)
 	$(AM_V_CCLD)$(LINK) $(dso_LDFLAGS) -o $@ \
 		-Wl,--soname,$@.$(VERSION) \
diff --git a/libdw/ChangeLog b/libdw/ChangeLog
index 94e9c9ab..79cce5ce 100644
--- a/libdw/ChangeLog
+++ b/libdw/ChangeLog
@@ -1,5 +1,9 @@
 2017-08-18  Ulf Hermann  <ulf.hermann@qt.io>
 
+	* Makefile.am: Drop libdw_so_SOURCES.
+
+2017-08-18  Ulf Hermann  <ulf.hermann@qt.io>
+
 	* memory-access.h: Use attribute_packed.
 
 2017-02-27  Ulf Hermann  <ulf.hermann@qt.io>
diff --git a/libdw/Makefile.am b/libdw/Makefile.am
index 8ee46802..af7d7793 100644
--- a/libdw/Makefile.am
+++ b/libdw/Makefile.am
@@ -106,7 +106,6 @@ libdw_so_LIBS = libdw_pic.a ../libdwelf/libdwelf_pic.a \
 	  ../libdwfl/libdwfl_pic.a ../libebl/libebl.a
 libdw_so_DEPS = ../lib/libeu.a ../libelf/libelf.so
 libdw_so_LDLIBS = $(libdw_so_DEPS) -ldl -lz $(argp_LDADD) $(zip_LIBS)
-libdw_so_SOURCES =
 libdw.so$(EXEEXT): $(srcdir)/libdw.map $(libdw_so_LIBS) $(libdw_so_DEPS)
 # The rpath is necessary for libebl because its $ORIGIN use will
 # not fly in a setuid executable that links in libdw.
diff --git a/libelf/ChangeLog b/libelf/ChangeLog
index 7bd9e1bc..23484499 100644
--- a/libelf/ChangeLog
+++ b/libelf/ChangeLog
@@ -1,5 +1,9 @@
 2017-08-18  Ulf Hermann  <ulf.hermann@qt.io>
 
+	* Makefile.am: Drop libelf_so_SOURCES.
+
+2017-08-18  Ulf Hermann  <ulf.hermann@qt.io>
+
 	* gelf_xlate.c: Use attribute_packed.
 
 2017-04-27  Ulf Hermann  <ulf.hermann@qt.io>
diff --git a/libelf/Makefile.am b/libelf/Makefile.am
index ddaeaa2b..a749a1bb 100644
--- a/libelf/Makefile.am
+++ b/libelf/Makefile.am
@@ -102,7 +102,6 @@ libelf_so_LDLIBS += -lpthread
 endif
 
 libelf_so_LIBS = libelf_pic.a
-libelf_so_SOURCES =
 libelf.so$(EXEEXT): $(srcdir)/libelf.map $(libelf_so_LIBS) $(libelf_so_DEPS)
 	$(AM_V_CCLD)$(LINK) $(dso_LDFLAGS) -o $@ \
 		-Wl,--soname,$@.$(VERSION) \
-- 
2.11.0

Re: [PATCH] Drop *_so_SOURCES from libasm, libdw, libelf Makefile.am

[Mark Wielaard]

On Fri, Aug 18, 2017 at 03:35:35PM +0200, Ulf Hermann wrote:
> They aren't used and cause warnings from autoconf.

Again I don't have internet access to lookup the autoconf manual.
But I don't believe this is correct. Removing the so_SOURCES is not
the same as leaving them empty. The change as proposed will break
make dist (or make distcheck) because removing it seems to cause
the default sources seem to be lib*.c.

What warnings did it cause for you? I am not seeing any.

Thanks,

Mark