Re: [PATCH v2] tests: do not fail on zero sized DIEs (binutils-2.39 compatible)

[Sergei Trofimovich <slyich@gmail.com>]

On Thu, 13 Oct 2022 16:40:36 +0200
Mark Wielaard <aegon@wildebeest.org> wrote:

> Hi,
> 
> On Mon, 2022-08-08 at 01:17 +0200, Mark Wielaard wrote:
> > On Sun, Aug 07, 2022 at 07:31:38PM +0100, Sergei Trofimovich via
> > Elfutils-devel wrote:  
> > > binutils started producing 0-sized DIEs on functions interspersed
> > > by nested sections (".section ...; .previous). This led to
> > > run-low_high_pc.sh failure in form of:
> > > 
> > >     FAIL: run-low_high_pc.sh
> > >     ========================
> > > 
> > >     [b] main.c
> > >     [2d] main
> > > 
> > >     [b] ../sysdeps/i386/start.S
> > >     [26] _start
> > >     [40] ../sysdeps/x86/abi-note.c
> > >     [b52] init.c
> > >     [b8e] static-reloc.c
> > >     [2dba] _dl_relocate_static_pie
> > >     [2dd8] ../sysdeps/i386/crti.S
> > >     [2def] _init
> > >     lowpc: 8049000, highpc: 8049000lx
> > >     ../sysdeps/i386/crti.S: [2def] '_init' highpc <= lowpc
> > >     FAIL run-low_high_pc.sh (exit status: 255)
> > > 
> > > To work it around let's allow lowpc == highpc special case.
> > > 
> > > https://sourceware.org/bugzilla/show_bug.cgi?id=29450  
> > 
> > Thanks for finding this and suggesting a workaround.  But lets first
> > try to fix binutils. This seems like a pretty bad bug, lets hope it
> > gets fixed soon. So we don't need these kind of workarounds.
> > 
> > I added a comment to the binutils bug:
> > https://sourceware.org/bugzilla/show_bug.cgi?id=29451#c2  
> 
> Since this binutils bug was fixed I assume this patch isn't needed
> anymore.

Agreed. https://sourceware.org/PR29450#c8 cosed the bug as RESOLVED/MOVED
to declare it a binutils deficiency. Downstream use binutils-2.39 with a
gas patch and are able to run unmodified elfutils testsuite as is.

Thank you!

-- 

  Sergei