public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: Ilya Leoshkevich <iii@linux.ibm.com>,
	"Frank Ch . Eigler" <fche@redhat.com>
Cc: elfutils-devel@sourceware.org
Subject: Re: [PATCH v3 4/4] configure: Add --enable-sanitize-memory
Date: Tue, 14 Feb 2023 15:25:24 +0100	[thread overview]
Message-ID: <4a08df1535efb0994e4548663d3cc10b59e5a74c.camel@klomp.org> (raw)
In-Reply-To: <20230213164551.550400-5-iii@linux.ibm.com>

Hi Ilya,

On Mon, 2023-02-13 at 17:45 +0100, Ilya Leoshkevich wrote:
> Add support for clang Memory Sanitizer [1], which detects the usage of
> uninitialized values. While elfutils itself is already checked with
> valgrind, checking code that depends on elfutils requires elfutils to
> be built with MSan.
> 
> MSan is not linked into shared libraries, and is linked into
> executables statically. Therefore, unlike the other sanitizers, MSan
> needs to be configured fairly early, since we need to drop
> -D_FORTIFY_SOURCE [2], -Wl,-z,defs and --no-undefined.
> 
> Disable a few tests that run for more than 5 minutes due to test files
> being statically linked with MSan.

Although I wasn't able to test this locally it looks all good. I did
check the _FORTIFY_SOURCE and like flags are still normal and no tests
are skipped without --enable-sanitize-memory.

Pushed.

Thanks,

Mark

      reply	other threads:[~2023-02-14 14:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-13 16:45 [PATCH v3 0/4] Add Memory Sanitizer support Ilya Leoshkevich
2023-02-13 16:45 ` [PATCH v3 1/4] tests: Ignore dwfl-report-offline-memory Ilya Leoshkevich
2023-02-14 13:38   ` (subset) " Mark Wielaard
2023-02-13 16:45 ` [PATCH v3 2/4] printversion: Fix unused variable Ilya Leoshkevich
2023-02-14 13:42   ` (subset) " Mark Wielaard
2023-02-13 16:45 ` [PATCH v3 3/4] backends: Support returning lvalue and rvalue references Ilya Leoshkevich
2023-02-14 14:16   ` Mark Wielaard
2023-02-13 16:45 ` [PATCH v3 4/4] configure: Add --enable-sanitize-memory Ilya Leoshkevich
2023-02-14 14:25   ` Mark Wielaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4a08df1535efb0994e4548663d3cc10b59e5a74c.camel@klomp.org \
    --to=mark@klomp.org \
    --cc=elfutils-devel@sourceware.org \
    --cc=fche@redhat.com \
    --cc=iii@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).