Re: [PATCH v3 3/4] backends: Support returning lvalue and rvalue references

[Mark Wielaard <mark@klomp.org>]

Hi Ilya,

On Mon, 2023-02-13 at 17:45 +0100, Ilya Leoshkevich wrote:
> On the low level, they are the same as pointers. The change needs to be
> done for all backends, so define a function and a macro to avoid
> repetition. Also add a native test, which has to be implemented in C++.
> Add the configure check for it.

I love everything about this patch (except for missing a ChangeLog
entry, but lets ignore that). The way you abstracted the pointer type
for the backends, the new test and the configure addition are all very
nice.

There is one small issue with the test. In case there is a C++11
compiler available run-funcretval++11.sh is added to TESTS twice, and
it is never added to EXTRA_DIST. So I pushed it with this small change:

diff --git a/tests/Makefile.am b/tests/Makefile.am
index bfc03061..efbb4e63 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -203,7 +203,7 @@ TESTS = run-arextract.sh run-arsymtest.sh run-ar.sh newfile test-nlist \
        $(asm_TESTS) run-disasm-bpf.sh run-low_high_pc-dw-form-indirect.sh \
        run-nvidia-extended-linemap-libdw.sh run-nvidia-extended-linemap-readelf.sh \
        run-readelf-dw-form-indirect.sh run-strip-largealign.sh \
-       run-readelf-Dd.sh run-funcretval++11.sh
+       run-readelf-Dd.sh
 
 if !BIARCH
 export ELFUTILS_DISABLE_BIARCH = 1
@@ -610,7 +610,8 @@ EXTRA_DIST = run-arextract.sh run-arsymtest.sh run-ar.sh \
             run-readelf-dw-form-indirect.sh testfile-dw-form-indirect.bz2 \
             run-nvidia-extended-linemap-libdw.sh run-nvidia-extended-linemap-readelf.sh \
             testfile_nvidia_linemap.bz2 \
-            testfile-largealign.o.bz2 run-strip-largealign.sh
+            testfile-largealign.o.bz2 run-strip-largealign.sh \
+            run-funcretval++11.sh
 
 
 if USE_VALGRIND

Thanks,

Mark