From: Ulf Hermann <ulf.hermann@qt.io>
To: elfutils-devel@sourceware.org
Subject: Re: ChangeLog entries (Was: [PATCH v3] Use fallthrough attribute)
Date: Mon, 12 Feb 2018 09:34:00 -0000 [thread overview]
Message-ID: <88598a77-c86f-2374-679f-a13e104d184b@qt.io> (raw)
In-Reply-To: <1518266386.3657.32.camel@klomp.org>
> For people that don't like them, what exactly is it about them that you
> don't like? And what would you suggest as replacement?
I don't like them because they constantly give me problems when merging and for me at least they only repeat, in a less convenient form, what the commit message already states. I like to put the "what" part in the commit message, too. And there I can write paragraphs of text that describe changes that span multiple directories. In ChangeLog I have to restrict myself to only that directory, which often doesn't make sense. So, the ChangeLog entries often are glorified "change line X in file Y", which doesn't really tell you what's going on. Also, the format encourages you to keep the ChangeLog entries overly short, which, especially in combination with the other problems, IMO makes them mostly unreadable.
So, as a replacement: Write more verbose commit messages.
br,
Ulf
prev parent reply other threads:[~2018-02-12 9:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 22:57 [PATCH] Add fallthrough attributes Joshua Watt
2018-02-08 23:30 ` [PATCH v2] " Joshua Watt
2018-02-09 9:08 ` Ulf Hermann
2018-02-09 9:27 ` Mark Wielaard
2018-02-09 14:19 ` Joshua Watt
2018-02-09 16:27 ` [PATCH v3] Use fallthrough attribute Joshua Watt
2018-02-10 2:26 ` Mark Wielaard
2018-02-10 3:36 ` Frank Ch. Eigler
2018-02-10 12:39 ` ChangeLog entries (Was: [PATCH v3] Use fallthrough attribute) Mark Wielaard
2018-02-12 9:34 ` Ulf Hermann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88598a77-c86f-2374-679f-a13e104d184b@qt.io \
--to=ulf.hermann@qt.io \
--cc=elfutils-devel@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).