From: Mark Wielaard <mark@klomp.org>
To: "Frank Ch. Eigler" <fche@redhat.com>
Cc: elfutils-devel@sourceware.org
Subject: ChangeLog entries (Was: [PATCH v3] Use fallthrough attribute)
Date: Sat, 10 Feb 2018 12:39:00 -0000 [thread overview]
Message-ID: <1518266386.3657.32.camel@klomp.org> (raw)
In-Reply-To: <20180210033631.GM24815@redhat.com>
On Fri, 2018-02-09 at 22:36 -0500, Frank Ch. Eigler wrote:
> On Sat, Feb 10, 2018 at 03:26:43AM +0100, Mark Wielaard wrote:
>
> > I added ChangeLog entries and pushed it to master.
>
> What's a ChangeLog entry? :-)
Yeah, yeah, I know. I am the last one to care.
Really, it helps me review code (even my own - actually writing them
makes me happy - o, right I did that!). If only to know a change is
really intended to be there.
To me the problem with dropping them is that there is no description
anymore what changed. The commit message normally describes why
something changed, not how. You of course have the diff to see what
changed, but not in a summary form. And I really like to have a summary
to cross check that what changed was intended to change.
For people that don't like them, what exactly is it about them that you
don't like? And what would you suggest as replacement?
Thanks,
Mark
next prev parent reply other threads:[~2018-02-10 12:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 22:57 [PATCH] Add fallthrough attributes Joshua Watt
2018-02-08 23:30 ` [PATCH v2] " Joshua Watt
2018-02-09 9:08 ` Ulf Hermann
2018-02-09 9:27 ` Mark Wielaard
2018-02-09 14:19 ` Joshua Watt
2018-02-09 16:27 ` [PATCH v3] Use fallthrough attribute Joshua Watt
2018-02-10 2:26 ` Mark Wielaard
2018-02-10 3:36 ` Frank Ch. Eigler
2018-02-10 12:39 ` Mark Wielaard [this message]
2018-02-12 9:34 ` ChangeLog entries (Was: [PATCH v3] Use fallthrough attribute) Ulf Hermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1518266386.3657.32.camel@klomp.org \
--to=mark@klomp.org \
--cc=elfutils-devel@sourceware.org \
--cc=fche@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).