From: Ulf Hermann <ulf.hermann@qt.io>
To: elfutils-devel@sourceware.org, jpewhacker@gmail.com
Subject: Re: [PATCH v2] Add fallthrough attributes
Date: Fri, 09 Feb 2018 09:08:00 -0000 [thread overview]
Message-ID: <c4582486-df50-d783-6bab-ce91c372d7c8@qt.io> (raw)
In-Reply-To: <20180208233010.11395-1-JPEWhacker@gmail.com>
> [...]
> +#ifdef HAVE_FALLTHROUGH
> + __attribute__ ((fallthrough));
> +#endif
> [...]
I would like to see this stanza wrapped in a macro, so that we only have one "#ifdef HAVE_FALLTHROUGH" in the code, not another one in every place we want to fall through. See the "internal_function" macro defined in lib/eu-config.h for a similar case.
Ulf
next prev parent reply other threads:[~2018-02-09 9:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 22:57 [PATCH] " Joshua Watt
2018-02-08 23:30 ` [PATCH v2] " Joshua Watt
2018-02-09 9:08 ` Ulf Hermann [this message]
2018-02-09 9:27 ` Mark Wielaard
2018-02-09 14:19 ` Joshua Watt
2018-02-09 16:27 ` [PATCH v3] Use fallthrough attribute Joshua Watt
2018-02-10 2:26 ` Mark Wielaard
2018-02-10 3:36 ` Frank Ch. Eigler
2018-02-10 12:39 ` ChangeLog entries (Was: [PATCH v3] Use fallthrough attribute) Mark Wielaard
2018-02-12 9:34 ` Ulf Hermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4582486-df50-d783-6bab-ce91c372d7c8@qt.io \
--to=ulf.hermann@qt.io \
--cc=elfutils-devel@sourceware.org \
--cc=jpewhacker@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).