public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: "Érico Nogueira" <ericonr@disroot.org>
Cc: elfutils-devel@sourceware.org, "Érico Nogueira" <erico.erc@gmail.com>
Subject: Re: [PATCH] debuginfod: fix compilation on platforms without <error.h>
Date: Thu, 11 Nov 2021 09:20:18 +0100	[thread overview]
Message-ID: <YYzSQqPnRh8orV1g@wildebeest.org> (raw)
In-Reply-To: <20211111001748.4977-1-ericonr@disroot.org>

Hi Érico,

On Wed, Nov 10, 2021 at 09:17:48PM -0300, Érico Nogueira via Elfutils-devel wrote:
> "system.h" only declares the error() function, so it needs to be in an
> 'extern "C"' block, otherwise linking fails.
> 
> Since we are here, use quotes for "system.h" header, since it's a local
> header, not a system one.

Thanks, applied.

Cheers,

Mark

  reply	other threads:[~2021-11-11  8:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-11  0:17 Érico Nogueira
2021-11-11  8:20 ` Mark Wielaard [this message]
2021-11-11  1:30 Érico Nogueira

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YYzSQqPnRh8orV1g@wildebeest.org \
    --to=mark@klomp.org \
    --cc=elfutils-devel@sourceware.org \
    --cc=erico.erc@gmail.com \
    --cc=ericonr@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).