* [PATCH] debuginfod: fix compilation on platforms without <error.h>
@ 2021-11-11 0:17 Érico Nogueira
2021-11-11 8:20 ` Mark Wielaard
0 siblings, 1 reply; 3+ messages in thread
From: Érico Nogueira @ 2021-11-11 0:17 UTC (permalink / raw)
To: elfutils-devel; +Cc: Érico Nogueira
From: Érico Nogueira <erico.erc@gmail.com>
"system.h" only declares the error() function, so it needs to be in an
'extern "C"' block, otherwise linking fails.
Since we are here, use quotes for "system.h" header, since it's a local
header, not a system one.
Signed-off-by: Érico Nogueira <erico.erc@gmail.com>
---
debuginfod/ChangeLog | 4 ++++
debuginfod/debuginfod.cxx | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/debuginfod/ChangeLog b/debuginfod/ChangeLog
index f06d3ee3..822bd637 100644
--- a/debuginfod/ChangeLog
+++ b/debuginfod/ChangeLog
@@ -1,3 +1,7 @@
+2021-11-10 Érico N. Rolim <erico.erc@gmail.com>
+
+ * debuginfod.cxx: include "system.h" under 'extern "C"' block.
+
2021-11-05 Frank Ch. Eigler <fche@redhat.com>
PR28430
diff --git a/debuginfod/debuginfod.cxx b/debuginfod/debuginfod.cxx
index 521cb529..764e7b94 100644
--- a/debuginfod/debuginfod.cxx
+++ b/debuginfod/debuginfod.cxx
@@ -33,11 +33,11 @@
extern "C" {
#include "printversion.h"
+#include "system.h"
}
#include "debuginfod.h"
#include <dwarf.h>
-#include <system.h>
#include <argp.h>
#ifdef __GNUC__
--
2.33.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] debuginfod: fix compilation on platforms without <error.h>
2021-11-11 0:17 [PATCH] debuginfod: fix compilation on platforms without <error.h> Érico Nogueira
@ 2021-11-11 8:20 ` Mark Wielaard
0 siblings, 0 replies; 3+ messages in thread
From: Mark Wielaard @ 2021-11-11 8:20 UTC (permalink / raw)
To: Érico Nogueira; +Cc: elfutils-devel, Érico Nogueira
Hi Érico,
On Wed, Nov 10, 2021 at 09:17:48PM -0300, Érico Nogueira via Elfutils-devel wrote:
> "system.h" only declares the error() function, so it needs to be in an
> 'extern "C"' block, otherwise linking fails.
>
> Since we are here, use quotes for "system.h" header, since it's a local
> header, not a system one.
Thanks, applied.
Cheers,
Mark
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] debuginfod: fix compilation on platforms without <error.h>
@ 2021-11-11 1:30 Érico Nogueira
0 siblings, 0 replies; 3+ messages in thread
From: Érico Nogueira @ 2021-11-11 1:30 UTC (permalink / raw)
To: elfutils-devel; +Cc: Érico Nogueira
From: Érico Nogueira <erico.erc@gmail.com>
"system.h" only declares the error() function, so it needs to be in an
'extern "C"' block, otherwise linking fails.
Since we are here, use quotes for "system.h" header, since it's a local
header, not a system one.
Signed-off-by: Érico Nogueira <erico.erc@gmail.com>
---
debuginfod/ChangeLog | 4 ++++
debuginfod/debuginfod.cxx | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/debuginfod/ChangeLog b/debuginfod/ChangeLog
index f06d3ee3..822bd637 100644
--- a/debuginfod/ChangeLog
+++ b/debuginfod/ChangeLog
@@ -1,3 +1,7 @@
+2021-11-10 Érico N. Rolim <erico.erc@gmail.com>
+
+ * debuginfod.cxx: include "system.h" under 'extern "C"' block.
+
2021-11-05 Frank Ch. Eigler <fche@redhat.com>
PR28430
diff --git a/debuginfod/debuginfod.cxx b/debuginfod/debuginfod.cxx
index 521cb529..764e7b94 100644
--- a/debuginfod/debuginfod.cxx
+++ b/debuginfod/debuginfod.cxx
@@ -33,11 +33,11 @@
extern "C" {
#include "printversion.h"
+#include "system.h"
}
#include "debuginfod.h"
#include <dwarf.h>
-#include <system.h>
#include <argp.h>
#ifdef __GNUC__
--
2.33.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-11 8:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-11 0:17 [PATCH] debuginfod: fix compilation on platforms without <error.h> Érico Nogueira
2021-11-11 8:20 ` Mark Wielaard
2021-11-11 1:30 Érico Nogueira
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).