* [Bug tools/23247] Segfault in 0.171 RC1 release candidate
2018-05-30 8:58 [Bug tools/23247] New: Segfault in 0.171 RC1 release candidate mliska at suse dot cz
@ 2018-05-30 9:29 ` mark at klomp dot org
2018-05-30 9:35 ` mark at klomp dot org
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: mark at klomp dot org @ 2018-05-30 9:29 UTC (permalink / raw)
To: elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=23247
Mark Wielaard <mark at klomp dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mark at klomp dot org
--- Comment #1 from Mark Wielaard <mark at klomp dot org> ---
Thanks, for some reason we used the wrong listptr for locview attributes.
This fixes it:
diff --git a/src/readelf.c b/src/readelf.c
index 2ccbea5..6f2f637 100644
--- a/src/readelf.c
+++ b/src/readelf.c
@@ -9244,7 +9244,7 @@ print_debug_loc_section (Dwfl_Module *dwflmod,
if (attr == DW_AT_GNU_locviews)
{
- Dwarf_Off next_off = next_listptr_offset (&known_loclistsptr,
+ Dwarf_Off next_off = next_listptr_offset (&known_locsptr,
listptr_idx);
const unsigned char *locp = readp;
const unsigned char *locendp;
While looking at this I also noticed that for this test file eu-readelf
--debug-dump=ranges claims to find some unused garbage in .debug_ranges, which
might indicate that we are either missing some attributes in the associated CU,
or GCC really puts garbage in the .debug_ranges section (which would surprise
me).
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread* [Bug tools/23247] Segfault in 0.171 RC1 release candidate
2018-05-30 8:58 [Bug tools/23247] New: Segfault in 0.171 RC1 release candidate mliska at suse dot cz
2018-05-30 9:29 ` [Bug tools/23247] " mark at klomp dot org
@ 2018-05-30 9:35 ` mark at klomp dot org
2018-05-30 10:14 ` mliska at suse dot cz
2018-05-31 19:19 ` mark at klomp dot org
3 siblings, 0 replies; 5+ messages in thread
From: mark at klomp dot org @ 2018-05-30 9:35 UTC (permalink / raw)
To: elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=23247
--- Comment #2 from Mark Wielaard <mark at klomp dot org> ---
(In reply to Mark Wielaard from comment #1)
> While looking at this I also noticed that for this test file eu-readelf
> --debug-dump=ranges claims to find some unused garbage in .debug_ranges,
> which might indicate that we are either missing some attributes in the
> associated CU, or GCC really puts garbage in the .debug_ranges section
> (which would surprise me).
That is odd. It seems eu-readelf really is correct, there is unused garbage in
the .debug_ranges sections, but not generated by GCC, but by GNU AS:
DWARF section [28] '.debug_info' at offset 0xe3c0:
[Offset]
Compilation unit at offset 0:
Version: 2, Abbreviation section offset: 0, Address size: 8, Offset size: 4
[ b] compile_unit abbrev: 1
stmt_list (data4) 0
ranges (data4) range list [ 0]
name (strp) "../sysdeps/x86_64/crti.S"
comp_dir (strp)
"/home/abuild/rpmbuild/BUILD/glibc-2.27/csu"
producer (strp) "GNU AS 2.30.0"
language (data2) Mips_Assembler (32769)
[...]
Compilation unit at offset 81846:
Version: 2, Abbreviation section offset: 6828, Address size: 8, Offset size: 4
[ 13fc1] compile_unit abbrev: 1
stmt_list (data4) 23645
ranges (data4) range list [ 21a0]
name (strp) "../sysdeps/x86_64/crtn.S"
comp_dir (strp)
"/home/abuild/rpmbuild/BUILD/glibc-2.27/csu"
producer (strp) "GNU AS 2.30.0"
language (data2) Mips_Assembler (32769)
DWARF section [33] '.debug_ranges' at offset 0x3e2b0:
CU [ b] base: +000000000000000000 <ELFUTILS_0.170.90>
[ 0] base address
+000000000000000000 <ELFUTILS_0.170.90>
[ 10] <UNUSED GARBAGE> ... 48 bytes ...
[...]
CU [ 13fc1] base: +000000000000000000 <ELFUTILS_0.170.90>
[ 21a0] base address
+000000000000000000 <ELFUTILS_0.170.90>
[ 21b0] <UNUSED GARBAGE IN REST OF SECTION>
All the other CU/ranges look fine. I assume that GNU AS is padding the section
for some reason. Anyway, this doesn't look like an eu-readelf bug.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread* [Bug tools/23247] Segfault in 0.171 RC1 release candidate
2018-05-30 8:58 [Bug tools/23247] New: Segfault in 0.171 RC1 release candidate mliska at suse dot cz
2018-05-30 9:29 ` [Bug tools/23247] " mark at klomp dot org
2018-05-30 9:35 ` mark at klomp dot org
@ 2018-05-30 10:14 ` mliska at suse dot cz
2018-05-31 19:19 ` mark at klomp dot org
3 siblings, 0 replies; 5+ messages in thread
From: mliska at suse dot cz @ 2018-05-30 10:14 UTC (permalink / raw)
To: elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=23247
--- Comment #3 from Martin Liska <mliska at suse dot cz> ---
(In reply to Mark Wielaard from comment #1)
> Thanks, for some reason we used the wrong listptr for locview attributes.
> This fixes it:
>
> diff --git a/src/readelf.c b/src/readelf.c
> index 2ccbea5..6f2f637 100644
> --- a/src/readelf.c
> +++ b/src/readelf.c
> @@ -9244,7 +9244,7 @@ print_debug_loc_section (Dwfl_Module *dwflmod,
>
> if (attr == DW_AT_GNU_locviews)
> {
> - Dwarf_Off next_off = next_listptr_offset (&known_loclistsptr,
> + Dwarf_Off next_off = next_listptr_offset (&known_locsptr,
> listptr_idx);
> const unsigned char *locp = readp;
> const unsigned char *locendp;
>
> While looking at this I also noticed that for this test file eu-readelf
> --debug-dump=ranges claims to find some unused garbage in .debug_ranges,
> which might indicate that we are either missing some attributes in the
> associated CU, or GCC really puts garbage in the .debug_ranges section
> (which would surprise me).
I can confirm it works for me! Thanks.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread* [Bug tools/23247] Segfault in 0.171 RC1 release candidate
2018-05-30 8:58 [Bug tools/23247] New: Segfault in 0.171 RC1 release candidate mliska at suse dot cz
` (2 preceding siblings ...)
2018-05-30 10:14 ` mliska at suse dot cz
@ 2018-05-31 19:19 ` mark at klomp dot org
3 siblings, 0 replies; 5+ messages in thread
From: mark at klomp dot org @ 2018-05-31 19:19 UTC (permalink / raw)
To: elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=23247
Mark Wielaard <mark at klomp dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
Resolution|--- |FIXED
--- Comment #4 from Mark Wielaard <mark at klomp dot org> ---
commit 84acd2365d4775b93aed5e5970b34db05ea5d547
Author: Mark Wielaard <mark@klomp.org>
Date: Wed May 30 11:54:31 2018 +0200
readelf: Use correct listptr when looking up next loc for locview attr.
We were using loclistsptr instead of locsptr in print_debug_loc_section.
https://sourceware.org/bugzilla/show_bug.cgi?id=23247
Signed-off-by: Mark Wielaard <mark@klomp.org>
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread