[Bug tools/28724] New: eu-elfclassify --no-stdin option is not effect

[Bug tools/28724] New: eu-elfclassify --no-stdin option is not effect

[panxh_ran at 163 dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28724

            Bug ID: 28724
           Summary: eu-elfclassify --no-stdin option is not effect
           Product: elfutils
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: tools
          Assignee: unassigned at sourceware dot org
          Reporter: panxh_ran at 163 dot com
                CC: elfutils-devel at sourceware dot org
  Target Milestone: ---

Created attachment 13879
  --> https://sourceware.org/bugzilla/attachment.cgi?id=13879&action=edit
the result of eu-elfclassify --no-stdin

eu-elfclassify --no-stdin option still reads files from standard input.
It seems that "no-stdin" used wrong enum member classify_flag_stdin instead of
classify_flag_no_stdin in src/elfclassify.c

 949       { "no-stdin", classify_flag_stdin, NULL, 0,
 950         N_("Do not read files from standard input (default)"), 2 },

Please confirm the result of eu-elfclassify --no-stdin with the attachment.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug tools/28724] eu-elfclassify --no-stdin option is not effect

[mark at klomp dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=28724

Mark Wielaard <mark at klomp dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |mark at klomp dot org

--- Comment #1 from Mark Wielaard <mark at klomp dot org> ---
Thanks, that was obviously a typo in the source. Nobody noticed before because
--no-stdin is the default. But it did indeed not work when given explicitly.

Fixed with:

commit 6398e94e9ac9a170da088768198d4a2b6e989e19 (HEAD -> master, origin/master,
origin/HEAD)
Author: Mark Wielaard <mark@klomp.org>
Date:   Sun Apr 24 17:48:39 2022 +0200

    elfclassify: Fix --no-stdin flag

    The no-stdin option was using the wrong flag, classify_flag_stdin,
    instead of classify_flag_no_stdin.

    https://sourceware.org/bugzilla/show_bug.cgi?id=28724

    Signed-off-by: Mark Wielaard <mark@klomp.org>

diff --git a/src/ChangeLog b/src/ChangeLog
index 6ef81862..fd87ce2f 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,7 @@
+2022-04-24  Mark Wielaard  <mark@klomp.org>
+
+       * elfclassify.c (main): Use classify_flag_no_stdin for no-std in
options.
+
 2022-04-19  Mark Wielaard  <mark@klomp.org>

        * readelf.c (get_dyn_ents): Define dyn_mem outside the while loop.
diff --git a/src/elfclassify.c b/src/elfclassify.c
index 2f70b29a..25fe9a65 100644
--- a/src/elfclassify.c
+++ b/src/elfclassify.c
@@ -946,7 +946,7 @@ separated by newlines"), 2 },
       { "stdin0", classify_flag_stdin0, NULL, 0,
         N_("Also read file names to process from standard input, \
 separated by ASCII NUL bytes"), 2 },
-      { "no-stdin", classify_flag_stdin, NULL, 0,
+      { "no-stdin", classify_flag_no_stdin, NULL, 0,
         N_("Do not read files from standard input (default)"), 2 },
       { "compressed", 'z', NULL, 0,
        N_("Try to open compressed files or embedded (kernel) ELF images"),

-- 
You are receiving this mail because:
You are on the CC list for the bug.