* [Bug general/30196] New: [0.189 regression] configure.ac contains Bashisms
@ 2023-03-05 2:44 sourceware at mattwhitlock dot name
2023-03-05 12:14 ` [Bug general/30196] " mark at klomp dot org
0 siblings, 1 reply; 2+ messages in thread
From: sourceware at mattwhitlock dot name @ 2023-03-05 2:44 UTC (permalink / raw)
To: elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=30196
Bug ID: 30196
Summary: [0.189 regression] configure.ac contains Bashisms
Product: elfutils
Version: unspecified
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: general
Assignee: unassigned at sourceware dot org
Reporter: sourceware at mattwhitlock dot name
CC: elfutils-devel at sourceware dot org
Target Milestone: ---
Created attachment 14729
--> https://sourceware.org/bugzilla/attachment.cgi?id=14729&action=edit
elfutils-0.189-fix-configure-bashisms.patch
Autoconf scripts are supposed to be written in POSIX-compatible shell language.
elfutils commits 0ffe2874e75d48cb88936e119e5284ff2bf664d9 and
3fa98a6f29b0f370e32549ead7eb897c839af980 introduced Bashisms to configure.ac
that cause errors when /bin/sh is not Bash.
Example error when /bin/sh is Dash:
./configure: 8748: test: xyes: unexpected operator
The cause of the error is the use of a non-existent == operator in expressions
passed to the 'test' built-in command. POSIX shell specifies only an = operator
for testing string equality.
Please make the corrections indicated in the attached patch.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 2+ messages in thread* [Bug general/30196] [0.189 regression] configure.ac contains Bashisms
2023-03-05 2:44 [Bug general/30196] New: [0.189 regression] configure.ac contains Bashisms sourceware at mattwhitlock dot name
@ 2023-03-05 12:14 ` mark at klomp dot org
0 siblings, 0 replies; 2+ messages in thread
From: mark at klomp dot org @ 2023-03-05 12:14 UTC (permalink / raw)
To: elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=30196
Mark Wielaard <mark at klomp dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mark at klomp dot org
Resolution|--- |FIXED
Status|UNCONFIRMED |RESOLVED
--- Comment #1 from Mark Wielaard <mark at klomp dot org> ---
You are completely right. Committed as:
commit a9834d7df68afde4ee44ee8fef888cf7e799171a
Author: Mark Wielaard <mark@klomp.org>
Date: Sun Mar 5 13:09:34 2023 +0100
configure.ac contains Bashisms
Autoconf scripts are supposed to be written in POSIX-compatible shell
language. elfutils commits 0ffe2874e75d48cb88936e119e5284ff2bf664d9
and 3fa98a6f29b0f370e32549ead7eb897c839af980 introduced Bashisms to
configure.ac that cause errors when /bin/sh is not Bash.
Example error when /bin/sh is Dash:
./configure: 8748: test: xyes: unexpected operator
The cause of the error is the use of a non-existent == operator in
expressions passed to the 'test' built-in command. POSIX shell
specifies only an = operator for testing string equality.
* configure.ac: Replace == by = in use_msan and enable_demangler
comparisons.
https://sourceware.org/bugzilla/show_bug.cgi?id=30196
Reported-by: Matt Whitlock <sourceware@mattwhitlock.name>
Signed-off-by: Mark Wielaard <mark@klomp.org>
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-05 12:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-05 2:44 [Bug general/30196] New: [0.189 regression] configure.ac contains Bashisms sourceware at mattwhitlock dot name
2023-03-05 12:14 ` [Bug general/30196] " mark at klomp dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).