* [Bug general/31027] New: Remove asserts from library code
@ 2023-11-02 13:43 amerey at redhat dot com
2023-11-08 23:35 ` [Bug general/31027] " dichen at redhat dot com
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: amerey at redhat dot com @ 2023-11-02 13:43 UTC (permalink / raw)
To: elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=31027
Bug ID: 31027
Summary: Remove asserts from library code
Product: elfutils
Version: unspecified
Status: NEW
Severity: normal
Priority: P2
Component: general
Assignee: unassigned at sourceware dot org
Reporter: amerey at redhat dot com
CC: elfutils-devel at sourceware dot org
Target Milestone: ---
It would be better for elfutils library functions to return an error code
instead of aborting because of a failed assert. For example see
https://sourceware.org/bugzilla/show_bug.cgi?id=30980
We should remove asserts from library code to prevent unnecessary aborts.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread* [Bug general/31027] Remove asserts from library code 2023-11-02 13:43 [Bug general/31027] New: Remove asserts from library code amerey at redhat dot com @ 2023-11-08 23:35 ` dichen at redhat dot com 2023-12-24 7:40 ` dichen at redhat dot com 2023-12-24 7:44 ` dichen at redhat dot com 2 siblings, 0 replies; 4+ messages in thread From: dichen at redhat dot com @ 2023-11-08 23:35 UTC (permalink / raw) To: elfutils-devel https://sourceware.org/bugzilla/show_bug.cgi?id=31027 Di Chen <dichen at redhat dot com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|unassigned at sourceware dot org |dichen at redhat dot com -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug general/31027] Remove asserts from library code 2023-11-02 13:43 [Bug general/31027] New: Remove asserts from library code amerey at redhat dot com 2023-11-08 23:35 ` [Bug general/31027] " dichen at redhat dot com @ 2023-12-24 7:40 ` dichen at redhat dot com 2023-12-24 7:44 ` dichen at redhat dot com 2 siblings, 0 replies; 4+ messages in thread From: dichen at redhat dot com @ 2023-12-24 7:40 UTC (permalink / raw) To: elfutils-devel https://sourceware.org/bugzilla/show_bug.cgi?id=31027 --- Comment #1 from Di Chen <dichen at redhat dot com> --- Asserts are heavily used across all elfutils libraries, and it's impossible to implement the removing in one commit. So let's gradually remove the asserts in the later coming commits. This is the first patch working on the removing: https://sourceware.org/pipermail/elfutils-devel/2023q4/006755.html -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug general/31027] Remove asserts from library code 2023-11-02 13:43 [Bug general/31027] New: Remove asserts from library code amerey at redhat dot com 2023-11-08 23:35 ` [Bug general/31027] " dichen at redhat dot com 2023-12-24 7:40 ` dichen at redhat dot com @ 2023-12-24 7:44 ` dichen at redhat dot com 2 siblings, 0 replies; 4+ messages in thread From: dichen at redhat dot com @ 2023-12-24 7:44 UTC (permalink / raw) To: elfutils-devel https://sourceware.org/bugzilla/show_bug.cgi?id=31027 --- Comment #2 from Di Chen <dichen at redhat dot com> --- I made a quick test on the libdwfl's asserts removing patch, and it passed. $ make check TESTS=run-dwfl* make check-TESTS PASS: run-dwfl-addr-sect.sh PASS: run-dwfl-bug-offline-rel.sh PASS: run-dwfl-core-noncontig.sh PASS: run-dwfllines.sh PASS: run-dwfl-report-elf-align.sh PASS: run-dwfl-report-offline-memory.sh PASS: run-dwflsyms.sh -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-12-24 7:44 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2023-11-02 13:43 [Bug general/31027] New: Remove asserts from library code amerey at redhat dot com 2023-11-08 23:35 ` [Bug general/31027] " dichen at redhat dot com 2023-12-24 7:40 ` dichen at redhat dot com 2023-12-24 7:44 ` dichen at redhat dot com
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).