[Bug general/31027] New: Remove asserts from library code

[Bug general/31027] New: Remove asserts from library code

[amerey at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=31027

            Bug ID: 31027
           Summary: Remove asserts from library code
           Product: elfutils
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: general
          Assignee: unassigned at sourceware dot org
          Reporter: amerey at redhat dot com
                CC: elfutils-devel at sourceware dot org
  Target Milestone: ---

It would be better for elfutils library functions to return an error code
instead of aborting because of a failed assert. For example see
https://sourceware.org/bugzilla/show_bug.cgi?id=30980

We should remove asserts from library code to prevent unnecessary aborts.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug general/31027] Remove asserts from library code

[dichen at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=31027

Di Chen <dichen at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at sourceware dot org   |dichen at redhat dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug general/31027] Remove asserts from library code

[dichen at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=31027

--- Comment #1 from Di Chen <dichen at redhat dot com> ---
Asserts are heavily used across all elfutils libraries, and it's
impossible to implement the removing in one commit. So let's gradually
remove the asserts in the later coming commits.

This is the first patch working on the removing:
https://sourceware.org/pipermail/elfutils-devel/2023q4/006755.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug general/31027] Remove asserts from library code

[dichen at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=31027

--- Comment #2 from Di Chen <dichen at redhat dot com> ---
I made a quick test on the libdwfl's asserts removing patch,
and it passed.

$ make check TESTS=run-dwfl*
make  check-TESTS
PASS: run-dwfl-addr-sect.sh
PASS: run-dwfl-bug-offline-rel.sh
PASS: run-dwfl-core-noncontig.sh
PASS: run-dwfllines.sh
PASS: run-dwfl-report-elf-align.sh
PASS: run-dwfl-report-offline-memory.sh
PASS: run-dwflsyms.sh

-- 
You are receiving this mail because:
You are on the CC list for the bug.